[squeak-dev] Merge Request: removeClass.cs

Marcel Taeumel marcel.taeumel at hpi.de
Thu Nov 18 16:09:00 UTC 2021


Well, I tried to find a more readable design for SystemNavigation >> #confirmAndRemoveClass: :-D

Best,
Marcel
Am 18.11.2021 17:05:14 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Thank you! (If the "Phew" was caused by any inefficiency on my side, I'm always interested to hear how I can improve my submission quality ... :-))

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 18. November 2021 17:02:26
An: squeak-dev
Betreff: Re: [squeak-dev] Merge Request: removeClass.cs
 
Merged. Phew. :-)

Best,
Marcel
Am 18.11.2021 11:26:39 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Sorry for that! Every mail client deserves a "you mentioned 'attachment' but did not add an attachment" warning ... This time it is really attached. :-)

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 18. November 2021 11:22:57
An: squeak-dev
Betreff: Re: [squeak-dev] Merge Request: removeClass.cs
 
Where to find the change set? It's not attached to the original email.

Best,
Marcel
Am 02.03.2021 18:26:16 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove as we know it from #removeMessage.



Please merge or give me feedback for improvements. :-)

Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211118/f90f574f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 23381 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211118/f90f574f/attachment.png>


More information about the Squeak-dev mailing list