[squeak-dev] The Trunk: Morphic-eem.1790.mcz
Eliot Miranda
eliot.miranda at gmail.com
Tue Nov 30 16:18:05 UTC 2021
> On Nov 29, 2021, at 8:52 AM, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
>
>
> Hi Christoph --
>
> This looks rather like a regression fix that is long overdue. See ParagraphEditor >> #makeProjektLink.
That’s right. I was editing help code and… bang! an MNU for makeProjectLink, which was there for ParagraphEditor, so I copied it over.
>
> Other than that: You are right. Coupling needs to decreased! Code needs to be documented! Context menus are crowded already! :-) So, let's work on that.
>
> Best,
> Marcel
>> Am 27.11.2021 20:34:20 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
>>
>> Hi Eliot,
>>
>>
>>
>> doesn't this increase the coupling between editing and projects management even more?
>>
>>
>>
>> Best,
>>
>> Christoph
>>
>> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
>> Gesendet: Donnerstag, 11. November 2021 18:11:49
>> An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
>> Betreff: [squeak-dev] The Trunk: Morphic-eem.1790.mcz
>>
>> Eliot Miranda uploaded a new version of Morphic to project The Trunk:
>> http://source.squeak.org/trunk/Morphic-eem.1790.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Morphic-eem.1790
>> Author: eem
>> Time: 11 November 2021, 9:11:46.040429 am
>> UUID: fcf3f31e-f485-42d4-8863-29f2e3c2afed
>> Ancestors: Morphic-eem.1789
>>
>> Implement "make project link (P)" for the Morphic help editor.
>>
>> =============== Diff against Morphic-eem.1789 ===============
>>
>> Item was added:
>> + ----- Method: PluggableTextMorph>>makeProjectLink (in category 'menu commands') -----
>> + makeProjectLink
>> + self handleEdit: [textMorph editor makeProjectLink]!
>>
>> Item was added:
>> + ----- Method: TextEditor>>makeProjectLink (in category 'menu commands') -----
>> + makeProjectLink
>> + | attribute thisSel |
>> +
>> + thisSel := self selection.
>> +
>> + attribute := TextSqkProjectLink new.
>> + thisSel := attribute analyze: self selection asString.
>> +
>> + thisSel ifNil: [^ true].
>> + self replaceSelectionWith: (thisSel asText addAttribute: attribute).
>> + ^ true!
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211130/4d27f7c8/attachment.html>
More information about the Squeak-dev
mailing list
|