[squeak-dev] The Inbox: ReleaseBuilder-ct.219.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Oct 18 17:49:56 UTC 2021


A new version of ReleaseBuilder was added to project The Inbox:
http://source.squeak.org/inbox/ReleaseBuilder-ct.219.mcz

==================== Summary ====================

Name: ReleaseBuilder-ct.219
Author: ct
Time: 18 October 2021, 7:49:55.090559 pm
UUID: 627c50ba-c259-f44a-9745-b6d9844c1789
Ancestors: ReleaseBuilder-mt.216

Fixes #requestNextReleaseVersion to always assign both NextMajorVersion and NextMinorVersion. Since the 5.3 release, only the latter was initialized, causing "ReleaseBuilder versionString" to answer "Squeak6.3" without this patch.

Implements #cleanUp: on ReleaseBuilder. Also resets both variables immediately via postscript.

=============== Diff against ReleaseBuilder-mt.216 ===============

Item was added:
+ ----- Method: ReleaseBuilder class>>cleanUp: (in category 'initialize-release') -----
+ cleanUp: aggressive
+ 
+ 	DeferredTask := nil.
+ 	aggressive ifTrue: [
+ 		NextMajorVersion := NextMinorVersion := nil].
+ 	NextTask := nil.
+ 	QAndA := nil.!

Item was changed:
  ----- Method: ReleaseBuilder class>>requestNextReleaseVersion (in category 'manual') -----
  requestNextReleaseVersion
  	"self requestNextReleaseVersion"
  	
+ 	| nextMinor nextMajor current next |
- 	| nextMinor nextMajor current |
  	current := {
  		SystemVersion current majorVersionNumber.
  		SystemVersion current minorVersionNumber}.
  	nextMinor := {
  		current first.
  		current second + 1}.
  	nextMajor := {
  		current first + 1.
  		0}.
  
+ 	next := Project uiManager
+ 		chooseFromLabeledValues: (OrderedDictionary new
+ 			at: ('{1}.{2}' format: {nextMinor first. nextMinor second}) put: nextMinor;
+ 			at: ('{1}.{2}' format: {nextMajor first. nextMajor second}) put: nextMajor;
+ 			yourself)
+ 		title: 'Please Choose Next Version'.
+ 	next ifNil: [^ self requestNextReleaseVersion].
+ 	NextMajorVersion := next first.
+ 	NextMinorVersion := next second.!
- 	(UIManager default
- 		chooseFrom: {
- 			'{1}.{2}' format: {nextMinor first. nextMinor second}.
- 			'{1}.{2}' format: {nextMajor first. nextMajor second}}
- 		title: 'Please Choose Next Version') in: [:answer |
- 			answer ifNil: [^ self requestNextReleaseVersion].
- 			answer = 1 ifTrue: [
- 				NextMinorVersion := nextMinor second].
- 			answer = 2 ifTrue: [
- 				NextMajorVersion := nextMajor first.
- 				NextMinorVersion := 0]].!

Item was changed:
+ (PackageInfo named: 'ReleaseBuilder') postscript: 'ReleaseBuilder classPool
+ 	at: #NextMajorVersion put: nil;
+ 	at: #NextMinorVersion put: nil.'!
- (PackageInfo named: 'ReleaseBuilder') postscript: '"See forum.world.st/NOTICE-Duplicate-Monticello-version-names-td5117695.html"
- MCMcmUpdater default dependentPackages do: [:package |
- 	package workingCopy repositoryGroup
- 		addRepository: MCRepository inbox;
- 		addRepository: MCRepository treated].
- '!



More information about the Squeak-dev mailing list