[squeak-dev] Bug in trunk? 'select all' in Workspace, line counting issue?

Marcel Taeumel marcel.taeumel at hpi.de
Mon Apr 25 09:19:55 UTC 2022


Hi Tim --

Hopefully fixed via Morphic-mt.1970.

Best,
Marcel
Am 25.04.2022 11:15:05 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
> I also noticed that the cursor always jumps to the beginning
> of a word, regardless whether you jump forward or backward. Hmm...

Nevermind. That was back in 4.5. We fixed this by now.
Am 25.04.2022 11:12:52 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Hi Tim --

In general, CMD+[Left/Right] do still move the cursor word-by-word. Pick a piece of source code and try.

Yet, the special case you mentioned somehow changed. I also noticed that the cursor always jumps to the beginning of a word, regardless whether you jump forward or backward. Hmm...

I will try to figure out that special case were multiple lines only have a single word.

Best,
Marcel
Am 22.04.2022 23:30:23 schrieb Tim Johnson <digit at sonic.net>:
Actually, I have tested this out a bit more.

A fresh code pane exhibits the same behavior, when going from the method template text to just, e.g.


...new lines are no longer being treated as tokenizers or whitespace(?) when doing Cmd-Left and Cmd-Right.

But if I add a space somewhere... like after "first"


... then Cmd-Left and Cmd-Right will happily stop there.

In Squeak 4.5 (and quite possibly other versions), the cursor will stop at the beginning of each new line (e.g. before first, before second, before third) when doing Cmd-Left and Cmd-Right in a pane like this.

Maybe this change was intentional?  But not what I'm expecting, or am used to.

Thanks again,
Tim



On Apr 22, 2022, at 12:53 PM, Tim Johnson <digit at sonic.net [mailto:digit at sonic.net]> wrote:

Thanks Marcel!  This is working here now, 6.0alpha-21644.

Unfortunately when testing this, I'm noticing another change I didn't expect. Cmd-Left Arrow and Cmd-Right Arrow do not navigate between words in the Workspace anymore.  All Cmd-arrow keys (up, down, left, right) now move to the beginning/end of the Workspace text.  

Was this an intentional change?  If so, I'm dismayed — not only because it breaks my muscle memory from ~fifteen years of using this, but also because it's now inconsistent with how code panes in Browser work (Cmd-Left/Right arrow still navigate between tokens/words in browser code panes...) and having Workspace keyboard navigation work differently from code pane keyboard navigation seems non-ideal...?

For what it's worth, I noticed that Home/End (a.k.a. Fn-Left and Fn-Right on an Apple keyboard) seem to retain their behavior of going to the beginning/end of line, so that's at least comforting.  :) 

Thanks again,
Tim


On Apr 17, 2022, at 6:04 AM, Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> wrote:

Hi Tim --

Fixed via Graphics-mt.509. Test in MorphicTests-mt.86.

Best,
Marcel
Am 13.04.2022 16:14:26 schrieb Tim Johnson <digit at sonic.net [mailto:digit at sonic.net]>:
Thanks Marcel.  Happy to help.  Using Trunk for regular tasks is sometimes challenging, but necessary and fruitful.  : )

I'd love to see a SUnit test against this if possible.  Maybe I can write one.  It's been a while.


On Apr 12, 2022, at 6:32 AM, Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> wrote:

Wohoo! You can reproduce that bug. Thanks! It is related to paragraph re-composition. Now I can finally debug it. Thanks! :-)

Best,
Marcel
Am 12.04.2022 01:47:57 schrieb Tim Johnson <digit at sonic.net [mailto:digit at sonic.net]>:
Hi all,

Just noticed something wrong in Workspace in Squeak6.0alpha-21580-64bit (2022-04-09)...

Enter four lines in Workspace, with a trailing carriage return.  Do a select all.  All lines are selected.

<Screen Shot 2022-04-11 at 4.45.14 PM.png>

then press some key to make it unselected  (say, cursor down arrow key)

then go back and delete the second line (I use arrow keys and then Shift-down and then backspace)  

then do a Select-all again ... if your situation is like mine, the last line will not be part of the range selected...

<Screen Shot 2022-04-11 at 4.46.30 PM.png>

I tested this on two images: one which I customized the preferences to my liking, as well as a fresh one where I just clicked "Skip" for the configuration wizard...

Can someone verify?

Are we filing bugs on GitHub now?  I might still have my Mantis login if needed... :) 

Tim






-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220425/48a49b11/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2022-04-22 at 2.25.16 PM.png
Type: image/png
Size: 10657 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220425/48a49b11/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2022-04-22 at 2.26.17 PM.png
Type: image/png
Size: 10717 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220425/48a49b11/attachment-0001.png>


More information about the Squeak-dev mailing list