[squeak-dev] The Trunk: Graphics-mt.513.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Apr 25 14:16:41 UTC 2022


Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mt.513.mcz

==================== Summary ====================

Name: Graphics-mt.513
Author: mt
Time: 25 April 2022, 4:16:34.244696 pm
UUID: dd521902-98db-e048-9702-83fcac30fee6
Ancestors: Graphics-mt.512

Tweak no-cursor-scale-on-macOS workaround to only be used directly before calling #beCursor and not in #scaleIconToDisplay, which also would affect Morphic cursors.

=============== Diff against Graphics-mt.512 ===============

Item was changed:
  ----- Method: Cursor class>>currentCursor: (in category 'current cursor') -----
  currentCursor: aCursor 
  	"Make the instance of cursor, aCursor, be the current cursor. Display it. 
  	Create an error if the argument is not a Cursor."
  
  	(aCursor isKindOf: self)
  		ifTrue: [ | platformCursor |
  			CurrentCursor := aCursor. "unscaled"
+ 			self flag: #todo. "mt: The current OSVM platform code for macOS has an issue with *not* scaling up hardware cursors for Retina displays. So we avoid scaling it here and let the OS do it. Note that this is not good because we could never provide a high-resolution cursor from within Squeak since the OS would scale it up anyway."
+ 			Smalltalk platformName = 'Mac OS'
+ 				ifTrue: [platformCursor := aCursor]
+ 				ifFalse: [platformCursor := aCursor scaleIconToDisplay].
- 			platformCursor := aCursor scaleIconToDisplay.
  			self useBiggerCursors
  				ifTrue: [platformCursor := platformCursor enlargedBy: 2].
  			platformCursor beCursor]
  		ifFalse: [self error: 'The new cursor must be an instance of class Cursor']!

Item was changed:
  ----- Method: Cursor>>scaleIconToDisplay (in category 'converting') -----
  scaleIconToDisplay
  	"Overwritten to use the custom #enlargedBy: method to scale up the receiver."
  	
- 	self flag: #todo. "mt: The current OSVM platform code for macOS has an issue with *not* scaling up hardware cursors for Retina displays. So we avoid scaling it here and let the OS do it. Note that this is not good because we could never provide a high-resolution cursor from within Squeak since the OS would scale it up anyway."
- 	Smalltalk platformName = 'Mac OS' ifTrue: [^ self].
- 	
  	^ self enlargedBy: (RealEstateAgent scaleFactor max: 1)!



More information about the Squeak-dev mailing list