> So should we add a few such messages before we deprecate TTCFontSet (should we deprecate?)

For Squeak 6.0, leave it be in "TrueType-Legacy" I suppose. After the release, take another look at it. It is still connected to how #leadingChar is used. Thus, it makes no sense to deprecated it at the moment.

Best,
Marcel
Am 26.04.2022 13:37:16 schrieb Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>:
Hi Marcel,

Le mar. 26 avr. 2022 à 11:19, Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> a écrit :

Hi Nicolas --

During the last 3 months of updating stuff in Trunk, I made 2 bigger mistakes that might raise debuggers when updating older Trunk images.
Not contributing and let code rotting gently might be a bigger mistake IMO. Thanks for taking the risks!
 


1. I was not aware that TTCFontSet was actually in use even for simple latin-1/ascii systems. Any MNU can simply be fixed by forwarding the implementation of that message to "fontArray first" in the font set.

So should we add a few such messages before we deprecate TTCFontSet (should we deprecate?)
 

2. I introduced a circular/EE issue around "LocaleID class >> #default" when a GetTextTranslator is active. So, it is best to just add this method with " ^ self isoLanguage: 'en' " as body before doing any update.

Note that all font stuff can be cleaned up via the ReleaseBuilder:

   ReleaseBuilder cleanUpBitstreamVeraSans.

worked perfectly, thanks.
 

Other font-related issues might be cleared by resetting the UI theme:

   UserInterfaceTheme cleanUpAndReset.

After that, no font sets should be present anymore. As documented in the Character class comment, both StrikeFontSet and TTCFontSet are considered legacy at this point.

Best,
Marcel
Am 25.04.2022 23:23:27 schrieb Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com [mailto:nicolas.cellier.aka.nice at gmail.com]>:
Hi all, Marcel,

Playing with FontChooser, I've encountered a MNU,
when selecting a TTCFont not having the preselected size:

TTCFontSet doesNotUnderstand: #familyNameAsIs

If I inspect the TTCFont with description 'Bitstream Vera Sans'-'Roman', I see that derivatives first class = TTCFontSet.

I also see a workaround for the (self flag: #legacy) case when fontArray first would be kind of TTCFontSet in TextStyle>>#addNewFontSize:, unfortunately, my case is derivatives first, not fontArray first...

It's possible that I skipped some non working postscripts that were once broken when updating the image, so maybe it's just me?

Nicolas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220426/35b8a07f/attachment.html>