[squeak-dev] The Trunk: System-mt.1309.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Feb 11 10:34:52 UTC 2022


Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.1309.mcz

==================== Summary ====================

Name: System-mt.1309
Author: mt
Time: 11 February 2022, 11:34:49.023944 am
UUID: 260fcd3c-331c-c345-8a27-8073fb63438c
Ancestors: System-mt.1308

Clarify the role of #themePriority. You cannot control the order of objects except for the classes. #allObjectsDo: will do the rest because it is reasonably fast.

=============== Diff against System-mt.1308 ===============

Item was changed:
  ----- Method: Object class>>themePriority (in category '*System-Preferences') -----
  themePriority
+ 	"Use this hook to control the order of class-side cache invalidation during theme updates. This means that caches that build upon each other can now be ordered. For example, TheWorldMainDockingBar should only be updated *after* MorphicToolBuilder reset its layout hints.
- 	"Use this hook to control the order of theme updates. For example, caches that are reused beyond a the scope of a single object should have a higher priority to be called first. Such caches are in TextAction, SHTextStylerST80, and TextDiffBuilder.
  	
  	We use the process priority model. 10 means low priority and 80 means high priority."
  
  	^ 0!

Item was changed:
  ----- Method: UserInterfaceTheme>>basicApply (in category 'private') -----
  basicApply
  	"Private. See #apply."
  
  	| classes |
  	classes := self class clientClassesToReapply. "Keep for fast #includes: check"
  	(classes sorted: [:a :b | a themePriority >= b themePriority]) do: [:eachClass |
  		(eachClass class includesSelector: #applyUserInterfaceTheme)
  			ifTrue: [eachClass applyUserInterfaceTheme]].
+ 
+ 	Cursor wait showWhile: [
+ 		SystemNavigation default allObjectsDo: [:o |
+ 			((classes includes: o class)
+ 				and: [o canApplyUserInterfaceTheme])
+ 					ifTrue: [o applyUserInterfaceTheme]]].!
- 		Cursor wait showWhile: [
- 			SystemNavigation default allObjectsDo: [:o |
- 				((classes includes: o class)
- 					and: [o canApplyUserInterfaceTheme])
- 						ifTrue: [o applyUserInterfaceTheme]]].!



More information about the Squeak-dev mailing list