> But no, it does not fix the "excessive size" limit in the email updates

Then this might be another to-do for SqueakSource at any point in time: Increase this limit? I don't think we lack the necessary resources today. Maybe we should also support something like "diff excerpts" without printing out all unchanged lines. However, nitpicking only. :-)

Best,
Christoph

---
Sent from Squeak Inbox Talk

On 2022-02-24T19:05:54-05:00, lewis at mail.msen.com wrote:

> On Thu, Feb 24, 2022 at 09:44:48PM +0000, Thiede, Christoph wrote:
> > +1, maybe this change will even eliminate the "(excessive size, no diff calculated)" messages on the list? :-)
> > 
> > 
> > Best,
> > 
> > Christoph
> > 
> 
> Yes it makes the diffing in the image readable. But no, it does not fix
> the "excessive size" limit in the email updates, see the commit notice at
> http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-February/219046.html
> for example.
> 
> For that I guess we would need to generate a context diff. But I don't
> think that this is very important, the main thing is that you can now
> see the method changes in the image.
> 
> Dave
> 
> 
> > ________________________________
> > Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
> > Gesendet: Mittwoch, 9. Februar 2022 17:57:49
> > An: squeak-dev
> > Betreff: Re: [squeak-dev] The Inbox: System-dtl.1304.mcz
> > 
> > Hi Dave --
> > 
> > Nice idea. Well, #privateAuthorsRaw was meant to be a small database. Like those base64 encoded icon contents. If you really want to see nicer diffs for this method, go ahead at update it. :-) Then we can also see whether we remove something by accident.
> > 
> > Best,
> > Marcel
> > 
> > Am 09.02.2022 02:54:29 schrieb commits at source.squeak.org <commits at source.squeak.org>:
> > 
> > A new version of System was added to project The Inbox:
> > http://source.squeak.org/inbox/System-dtl.1304.mcz
> > 
> > ==================== Summary ====================
> > 
> > Name: System-dtl.1304
> > Author: dtl
> > Time: 8 February 2022, 8:54:15.36808 pm
> > UUID: 425a12bd-d324-4d48-91db-a29dfb4bb67b
> > Ancestors: System-mt.1303
> > 
> > Use Character cr as a separator in privateAuthorsRaw so that each author appears on a separate line in the method. Future updates will be readable in the version diffs.
> > 
> > =============== Diff against System-mt.1303 ===============
> > 
> > Item was changed:
> > ----- Method: SystemNavigation class>>initializeAuthors (in category 'class initialization') -----
> > initializeAuthors
> > "self initializeAuthors"
> > 
> > | s currentName currentAbbrv |
> > Authors := Dictionary new.
> > s := self privateAuthorsRaw readStream.
> > 
> > [s atEnd] whileFalse: [
> > "Read author name"
> > currentName := String streamContents: [:as |
> > [s peek ~= $#] whileTrue: [as nextPut: s next]].
> > Authors at: currentName put: Set new.
> > "Read abbreviations"
> > s next. "skip $#"
> > currentAbbrv := ''.
> > + [s atEnd not and: [s peek ~= Character cr]] whileTrue: [
> > - [s atEnd not and: [s peek ~= $!!]] whileTrue: [
> > s peek = $# ifTrue: [
> > (Authors at: currentName) add: currentAbbrv.
> > currentAbbrv := ''.
> > s next. "skip $#"].
> > currentAbbrv := currentAbbrv, s next asString. "slow..."
> > ].
> > currentAbbrv ifNotEmpty: [(Authors at: currentName) add: currentAbbrv].
> > s next. "skip $!!"
> > ].
> > 
> > "Fill inverted index for authors."
> > AuthorsInverted := Dictionary new.
> > Authors keysAndValuesDo: [:fullName :abbreviations |
> > abbreviations do: [:abbrv |
> > (AuthorsInverted
> > at: abbrv
> > ifAbsentPut: [Set new]) add: fullName]].!
> > 
> > Item was changed:
> > ----- Method: SystemNavigation class>>privateAuthorsRaw (in category 'class initialization') -----
> > (excessive size, no diff calculated)
> > 
> > 
> 
> >
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220225/9d9153d5/attachment.html>