[squeak-dev] The Inbox: Tools-ct.1136.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Feb 25 15:51:18 UTC 2022


A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.1136.mcz

==================== Summary ====================

Name: Tools-ct.1136
Author: ct
Time: 25 February 2022, 4:51:14.742129 pm
UUID: d3396d11-145e-294d-b51c-805c6b3b64ab
Ancestors: Tools-mt.1135

Revises senders/implementors in message traces so that:

* using the buttons always spawns a new window
* you can press shift to invert whether the new messages will be appended to the existing window or opened in a new window

See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-February/218946.html

=============== Diff against Tools-mt.1135 ===============

Item was changed:
  ----- Method: MessageTrace>>browseAllCallsOn:requestor: (in category 'actions') -----
  browseAllCallsOn: selectorSymbol requestor: anObject
  	"Overwritten to modify the trace if the request origins from a model-menu command such as the message-list menu (shortcut)."
  	
+ 	(((Preferences traceMessages and: [anObject ~= #button] and: [selectorSymbol = self selectedMessageName]) xor: Sensor shiftPressed)
+ 		and: [self hasUnacceptedEdits not])
- 	(selectorSymbol = self selectedMessageName
- 		and: [ Preferences traceMessages ] and: [ self hasUnacceptedEdits not ])
  			ifTrue: [ self addParentMethodsSending: selectorSymbol ]
  			ifFalse: [ super browseAllCallsOn: selectorSymbol requestor: anObject ].!

Item was changed:
  ----- Method: MessageTrace>>browseAllImplementorsOf:requestor: (in category 'actions') -----
  browseAllImplementorsOf: selectorSymbol requestor: anObject
  	"Overwritten to modify the trace if the request origins from a model-menu command such as the message-list menu (shortcut)."
  
  	| selectorToBrowse |
  	selectorToBrowse := self selection 
  		ifNil: [ selectorSymbol ] 
  		ifNotNil: [ self getImplementorNamed: selectorSymbol asSymbol "since we can get passed literals"].
+ 	(((Preferences traceMessages and: [anObject ~= #button]) xor: Sensor shiftPressed) and: [self hasUnacceptedEdits not])
- 	(Preferences traceMessages and: [ self hasUnacceptedEdits not ])
  		ifTrue: [ self addChildMethodsNamed: selectorToBrowse ]
  		ifFalse: [ super browseAllImplementorsOf: selectorToBrowse requestor: anObject ].!

Item was added:
+ ----- Method: MessageTrace>>browseMessagesFromButton (in category 'controls') -----
+ browseMessagesFromButton
+ 
+ 	self getSelectorAndSendQuery: #browseAllImplementorsOf:requestor: to: self with: #(button).!

Item was added:
+ ----- Method: MessageTrace>>browseSendersOfMessagesFromButton (in category 'controls') -----
+ browseSendersOfMessagesFromButton
+ 
+ 	self getSelectorAndSendQuery: #browseAllCallsOn:requestor: to: self with: #(button).!

Item was added:
+ ----- Method: MessageTrace>>optionalButtonPairs (in category 'controls') -----
+ optionalButtonPairs
+ 
+ 	^ super optionalButtonPairs collect: [:spec |
+ 		spec second
+ 			caseOf:
+ 				{[#browseSendersOfMessages] -> [spec copy
+ 					at: 2 put: #browseSendersOfMessagesFromButton;
+ 					yourself].
+ 				[#browseMessages] -> [spec copy
+ 					at: 2 put: #browseMessagesFromButton;
+ 					yourself]}
+ 			otherwise: [spec]]!



More information about the Squeak-dev mailing list