I agree with Chris here; though the split handling of the 1/more versions is nice.

As for the version name truncation, a nicer solution would be for the notifier UI to have a scrollbar if is it needed. And while fantasising, if there is more than one version to report using a UI list would be nice, especially since it would provide for a scrollbar in the eventuality that many items need listing.

> On 2022-01-09, at 5:25 PM, Chris Muller <asqueaker at gmail.com> wrote:
> 
> -1
> 
> Seeing, "Caution, do you really want to...," is kind of annoying because it's applying the "caution" to the user's intent BEFORE saying why.  
> 
> The old message applied the caution to the REASON, and THEN asked the user, "do you really want to...".
> 
> From that aspect, the old message is better.
> 
> 
> 
> 
> 
> On Mon, Jan 3, 2022 at 2:41 PM <commits at source.squeak.org> wrote:
> Christoph Thiede uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-ct.729.mcz
> 
> ==================== Summary ====================
> 
> Name: Monticello-ct.729
> Author: ct
> Time: 17 September 2020, 7:04:53.385813 pm
> UUID: 5eea47cc-405e-7841-9544-0f57a9b92fa0
> Ancestors: Monticello-cmm.726
> 
> Proposal: Enhance truncation of "newer versions avaiable" warning (and make it multilingual-ready)
> 
> =============== Diff against Monticello-cmm.726 ===============
> 
> Item was changed:
>   ----- Method: MCWorkingCopyBrowser>>checkForNewerVersions (in category 'actions') -----
>   checkForNewerVersions
> +       "Answer true if there are no newer versions preventing us from saving a version."
> + 
>         | newer |
>         newer := workingCopy possiblyNewerVersionsIn: self repository.
> +       
> +       newer ifEmpty: [^ true].
> +       
> +       ^ self confirm: ('CAUTION!! {1}:\{2}\Do you really want to save this version?' withCRs translated format: {
> +               newer size = 1
> +                       ifTrue: ['This version in the repository may be newer' translated]
> +                       ifFalse: ['These {1} versions in the repository may be newer' translated format: {newer size}].
> +               (newer size > 3
> +                       ifFalse: [newer]
> +                       ifTrue: [(newer first: 3) , {'...'} , {newer last}]) asCommaString withNoLineLongerThan: 150
> +       })!
> -       ^ newer isEmpty or: [
> -               self confirm: 'CAUTION!! These versions in the repository may be newer:', 
> -                       String cr, ((newer asCommaString withNoLineLongerThan:  150) truncateWithElipsisTo: 5 * 149), String cr,
> -                       'Do you really want to save this version?'].!
> 
> 
> 


tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Design simplicity: It was developed on a shoe-string budget.