Hi Christoph --

-1

It is surprising that the set* method returns an important value now. Just add "AuthorName" where it was missing. I will revise this.

Best,
Marcel
Am 10.01.2022 22:50:54 schrieb commits at source.squeak.org <commits at source.squeak.org>:
Christoph Thiede uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-ct.1279.mcz

==================== Summary ====================

Name: System-ct.1279
Author: xyz
Time: 10 January 2022, 10:50:35.316477 pm
UUID: 1116bbe8-61e2-5c42-9d22-c0536cf9059a
Ancestors: System-ct.1278

Fixes Utilities authorName which answered the receiver rather than the new author name for known authors ("Let the user confirm" case).

=============== Diff against System-ct.1278 ===============

Item was removed:
- ----- Method: Preferences class>>allowEtoyUserCustomEvents (in category 'standard queries') -----
- allowEtoyUserCustomEvents
- ^ self
- valueOfFlag: #allowEtoyUserCustomEvents
- ifAbsent: [false]!

Item was changed:
----- Method: Utilities class>>authorName (in category 'identification') -----
authorName
"Maybe interactive. Answer the full name to be used in various tools to identify the user/author. Ask the user if the name is empty. Try to derive the name from existing initials."

^ AuthorName ifEmpty: [
AuthorInitials
+ ifEmpty: [self setAuthorName]
- ifEmpty: [self setAuthorName. AuthorName]
ifNotEmpty: [:initials |
SystemNavigation authorsInverted
at: initials
ifPresent: [:authorNames |
AuthorName := authorNames sorted joinSeparatedBy: '/'.
self setAuthorName. "Let the user confirm"]
+ ifAbsent: [self setAuthorName]]]!
- ifAbsent: [self setAuthorName. AuthorName]]]!

Item was changed:
----- Method: Utilities class>>setAuthorName (in category 'identification') -----
setAuthorName

+ ^ AuthorName := Project uiManager
- AuthorName := Project uiManager
request: 'Please type your name:' translated
+ initialAnswer: (AuthorName ifEmpty: ['Your Name' translated])!
- initialAnswer: (AuthorName ifEmpty: ['Your Name' translated]).!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220111/cc6b75b5/attachment.html>