[squeak-dev] The Inbox: Morphic-ct.1846.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Jan 12 20:27:19 UTC 2022


A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1846.mcz

==================== Summary ====================

Name: Morphic-ct.1846
Author: ct
Time: 12 January 2022, 9:27:12.594139 pm
UUID: 0bf19b8c-e7ea-7145-9a79-b76aaaaa2543
Ancestors: Morphic-ct.1845

Proposal: Display that tedious "Enter text to narrow selection" tooltip only if novice mode is enabled.

Many of us might not have noticed this balloon text any more that appears every time you open a menu (unless #menuKeyboardControl is disabled), but it still is irrelevant for non-novice users and sometimes occludes other relevant information, for instance, during screenshots.

=============== Diff against Morphic-ct.1845 ===============

Item was changed:
  ----- Method: MenuMorph>>popUpAt:forHand:in:allowKeyboard: (in category 'control') -----
  popUpAt: aPoint forHand: hand in: aWorld allowKeyboard: aBoolean 
  	"Present this menu at the given point under control of the given 
  	hand."
  	| evt |
  	aWorld submorphs
  		select: [:each | (each isKindOf: MenuMorph)
  				and: [each stayUp not]]
  		thenCollect: [:menu | menu delete].
  	self items isEmpty
  		ifTrue: [^ self].
  	MenuIcons decorateMenu: self.
  	(self submorphs
  		select: [:m | m isKindOf: UpdatingMenuItemMorph])
  		do: [:m | m updateContents].
  	"precompute width"
  	self
  		positionAt: aPoint
  		relativeTo: (selectedItem
  				ifNil: [self items first])
  		inWorld: aWorld.
  	aWorld addMorphFront: self.
  	"Acquire focus for valid pop up behavior"
  	hand
  		newMouseFocus: self;
  		showTemporaryCursor: nil.
  	aBoolean
  		ifTrue: [
  			originalFocusHolder := hand keyboardFocus.
  			hand newKeyboardFocus: self.
+ 			Preferences noviceMode ifTrue: [
+ 				self showKeyboardHelp]].
- 			self showKeyboardHelp].
  	evt := hand lastEvent.
  	(evt isKeyboard
  			or: [evt isMouse
  					and: [evt anyButtonPressed not]])
  		ifTrue: ["Select first item if button not down"
  			self moveSelectionDown: 1 event: evt
  			"Select first item if button not down"].
  	self updateColor.
  	self changed!



More information about the Squeak-dev mailing list