[squeak-dev] The Inbox: ToolBuilder-Morphic-ct.286.mcz
commits at source.squeak.org
commits at source.squeak.org
Sat Jan 15 21:19:52 UTC 2022
A new version of ToolBuilder-Morphic was added to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.286.mcz
==================== Summary ====================
Name: ToolBuilder-Morphic-ct.286
Author: ct
Time: 15 January 2022, 10:19:51.009373 pm
UUID: 3c0068e7-ce8e-5f45-8782-34c92bc6ab5f
Ancestors: ToolBuilder-Morphic-ct.285
Fixes a nil MNU when interrupting a pluggable dialog.
Steps to reproduce (before):
1. Do it:
Project uiManager chooseFrom: ((1 to: 10) collect: #asWords).
2. Interrupt/Debug invocation
3. Close/cancel the dialog
4. Abandon the debugger
During the unwinding logic, the dialog window would attempt to close itself a second time, neglecting the fact that the model had already been released.
Inbox because only 90% sure that this is the right fix. :-)
=============== Diff against ToolBuilder-Morphic-ct.285 ===============
Item was changed:
----- Method: PluggableDialogWindow>>delete (in category 'submorphs - add/remove') -----
delete
+ self model ifNil: [^ super delete].
self model okToClose ifFalse: [^ self].
self closeDialogSelector ifNotNil: [:sel | self model perform: sel].
self model
windowIsClosing;
release.
self model: nil.
super delete.!
More information about the Squeak-dev
mailing list
|