Sorry, I meant to say "a second opinion would be welcome", not "a second option".

Dave

On Mon, Jan 17, 2022 at 11:39:05AM -0500, David T. Lewis wrote:
> Hi Marcel,
> 
> On Mon, Jan 17, 2022 at 12:56:01PM +0100, Marcel Taeumel wrote:
> > Hi Dave --
> > 
> > +1
> > 
> > Did you double-check whether it is safe to remove that interface on FileDirectory class???
> > 
> 
> I believe that it is safe, although a second option would be welcome.
> These are class side methods, but they are effectively private in
> the sense that they are used only for opening the source files. I
> think it's more or less a matter of style preference if you want
> to say this:
> 
> 	FileDirectory
> 		openSources: self sourcesName
> 		andChanges: self changesName
> 		forImage: LastImageName.
> 
> or this:
> 
> 	self
> 		openSourcesAndChanges: self changesName
> 		forImage: LastImageName.
> 
> To me it seemed like delegating to class FileDirectory was a bit
> strained, even though the code has been like that since the dawn of
> time.
> 
> BTW the easiest way to look at this is by stepping through "Smalltalk openSourceFiles"
> in a debugger. Note that there does seem to be some kind of Windows-related
> bug when you just doIt, but it seemed to work correctly in the debugger when
> I tried it on Windows.
> 
> Dave
> 
> 
> > Best,
> > Marcel
> > Am 02.01.2022 09:42:09 schrieb David T. Lewis <lewis at mail.msen.com>:
> > See discussion at:
> > 
> > http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-January/218008.html
> > 
> > Dave
> > 
> > On Sat, Jan 01, 2022 at 08:47:18PM +0000, commits at source.squeak.org wrote:
> > > A new version of System was added to project The Inbox:
> > > http://source.squeak.org/inbox/System-dtl.1277.mcz
> > >
> > > ==================== Summary ====================
> > >
> > > Name: System-dtl.1277
> > > Author: dtl
> > > Time: 1 January 2022, 2:57:48.389886 pm
> > > UUID: 4d975f20-d62d-4b7e-8abb-bc511d976834
> > > Ancestors: System-mt.1276
> > >
> > > Look for the sources file in well-known locations on some platforms. For Unix, if not found in the usual locations then look in /usr/share/squeak and /usr/local/share/squeak. Hooks for other platforms may be added to SmalltalkImage>>sourcesFilePaths.
> > >
> > > Refactor to reduce duplication of logic in locateSourcesEntry and openSources:forImage: and to ensure that the full set of file paths is searched for stc compressed sources files prior to searching for regular sources files.
> > >
> > > =============== Diff against System-mt.1276 ===============
> > >
> > 
> 
> >