[squeak-dev] The Trunk: PreferenceBrowser-dtl.127.mcz
commits at source.squeak.org
commits at source.squeak.org
Fri Jan 21 23:50:12 UTC 2022
David T. Lewis uploaded a new version of PreferenceBrowser to project The Trunk:
http://source.squeak.org/trunk/PreferenceBrowser-dtl.127.mcz
==================== Summary ====================
Name: PreferenceBrowser-dtl.127
Author: dtl
Time: 21 January 2022, 6:48:18.107006 pm
UUID: 36db7347-7bae-40f0-a3bf-c9723835a3cc
Ancestors: PreferenceBrowser-mt.126
Let the PreferenceWizard first check internet connectivity, then check for secure https. Avoids misleading user message for the case of a successfully connected computer but https not availble due to a SqueakSSL plugin issue. A specific edge case is that of a current VM running on an older Linux distribution on which the SqueakSSL plugin fails to load required OS libraries, leading to https failures even though the internet connection is available.
=============== Diff against PreferenceBrowser-mt.126 ===============
Item was changed:
----- Method: PreferenceWizardMorph>>checkInternetOn: (in category 'updating') -----
checkInternetOn: button
self isInWorld ifFalse: [^ self].
(self hasProperty: #checkInternet) ifFalse: [^ self].
self hasInternetConnection
+ ifFalse: [button enabled: false; label: 'Please check your internet connection...' translated]
+ ifTrue: [^ self hasSecureInternetConnection
+ ifFalse: [button enabled: false; label: 'Secure https not available, possible virtual machine issue' translated]
+ ifTrue: [button enabled: true; label: 'Yes, install selected packages.' translated]].
+
- ifTrue: [button enabled: true; label: 'Yes, install selected packages.' translated]
- ifFalse: [button enabled: false; label: 'Please check your internet connection...' translated].
-
(self future: 1000) checkInternetOn: button.!
Item was changed:
----- Method: PreferenceWizardMorph>>hasInternetConnection (in category 'testing') -----
hasInternetConnection
+ ^ [TestCase new ensureInternetConnection. true]
- ^ [TestCase new ensureSecureInternetConnection. true]
on: Error do: [false]!
Item was added:
+ ----- Method: PreferenceWizardMorph>>hasSecureInternetConnection (in category 'testing') -----
+ hasSecureInternetConnection
+
+ ^ [TestCase new ensureSecureInternetConnection. true]
+ on: Error do: [false]!
More information about the Squeak-dev
mailing list
|