[squeak-dev] Small diff for the new Joystick updates on old enough Linux

Tobias Pape Das.Linux at gmx.de
Tue Jun 14 09:47:54 UTC 2022


Hi Bruce,


> On 13. Jun 2022, at 17:17, Bruce O'Neel <bruce.oneel at pckswarms.ch> wrote:
> 
> Hi,
> 
> I am sending this just to save the next person who stumbles over the new Joystick stuff not building on old enough linuxes some time.  In my case old enough is RedHat 7.
> 
> We should not add complexity to make this automagic.  But when someone says "does not build on Linux kernels 3.x or so", I know, ancient, we can say "here, this patch."

I am actually quite puzzled.
I've checked on ubuntu 20.04 and 22.04, and there the include file and the defined constants exist.
(With the linux-libc-dev package installed)

On RHEL, you just need the kernel-headers package, and there you are :)

Best regards
	-Tobias

> 
> cheers
> 
> bruce
> 
> 
> 
> git diff ../../../../platforms/unix/plugins/JoystickTabletPlugin/sqUnixJoystickTablet.c
> diff --git a/platforms/unix/plugins/JoystickTabletPlugin/sqUnixJoystickTablet.c b/platforms/unix/plugins/JoystickTabletPlugin/sqUnixJoys
> index b2e69c7..a3baf8d 100644
> --- a/platforms/unix/plugins/JoystickTabletPlugin/sqUnixJoystickTablet.c
> +++ b/platforms/unix/plugins/JoystickTabletPlugin/sqUnixJoystickTablet.c
> @@ -26,7 +26,7 @@
>   */
> 
> /* Author: Ian.Piumarta at INRIA.Fr
> -/* Author: davidf at afeka.ac.il
> + Author: davidf at afeka.ac.il
>   */
> 
> #include <assert.h>
> @@ -42,7 +42,7 @@
> #include <dirent.h>
> #include <errno.h>
> #include <poll.h>
> -#include <linux/input-event-codes.h>
> +// #include <linux/input-event-codes.h>
> #include <linux/input.h>
> #include "JoystickTabletPlugin.h"
> 
> @@ -161,10 +161,10 @@ detectButtons(joystick_state_t* pj)
>         else {
>                 // it's a modern gamepad device
> 
> -               pj->button_index[0] = BTN_NORTH;
> +/*             pj->button_index[0] = BTN_NORTH;
>                 pj->button_index[1] = BTN_EAST;
>                 pj->button_index[2] = BTN_SOUTH;
> -               pj->button_index[3] = BTN_WEST;
> +               pj->button_index[3] = BTN_WEST; */
>         }
> 
>         return 1;
> 
> 
> 




More information about the Squeak-dev mailing list