Thanks! This one has been bothering me for quite some time.

Best,
Marcel
Am 14.06.2022 20:59:46 schrieb commits at source.squeak.org <commits at source.squeak.org>:
Eliot Miranda uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-eem.1361.mcz

==================== Summary ====================

Name: System-eem.1361
Author: eem
Time: 14 June 2022, 11:59:30.191277 am
UUID: 0269091d-007e-4db6-a77d-c459b689b7d1
Ancestors: System-dtl.1360

Scope vareiable references (especially class variable references and property variable accesses (Tweak et al)) to the defining class, rather thna the whole system. Since allCallsOn:from: is broken, use allCallsOn:localTo: in browseAllCallsOn:localTo:

[e.g. the first two are ok; the last is broken.
self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) an OrderedCollection(a MethodReference EventSensor class >> #eventPollPeriod a MethodReference EventSensor class >> #eventPollPeriod:)
self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) localTo: EventSensor an OrderedCollection(a MethodReference EventSensor class >> #eventPollPeriod a MethodReference EventSensor class >> #eventPollPeriod:)
self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) from: EventSensor an OrderedCollection() ]

=============== Diff against System-dtl.1360 ===============

Item was changed:
----- Method: SystemNavigation>>browseAllCallsOn:localTo: (in category 'browse') -----
browseAllCallsOn: aLiteral localTo: aBehavior
"Create and schedule a message browser on each method in or below the given class that refers to aLiteral."
"self default browseAllCallsOn: #open:label: localTo: CodeHolder"

aBehavior ifNil: [ ^self inform: 'No behavior selected.' ].
^ self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect |
self
+ browseMessageList: [ self allCallsOn: aLiteral localTo: aBehavior ]
- browseMessageList: [ self allCallsOn: aLiteral from: aBehavior ]
name: label, ' local to ', aBehavior name
autoSelect: autoSelect ]!

Item was changed:
----- Method: SystemNavigation>>browseVariableReferences: (in category 'browse') -----
browseVariableReferences: aClass
aClass chooseVarThenDo:
+ [:aVar |
+ (aClass allInstVarNames includes: aVar)
- [ : aVar | (aClass allInstVarNames includes: aVar)
ifTrue:
+ [self browseAllAccessesTo: aVar from: aClass]
+ ifFalse:
+ [((aClass classThatDefinesInstanceVariable: aVar) ifNil:
+ [(aClass includesBehavior: SharedPool) ifFalse:
+ [aClass classThatDefinesClassVariable: aVar]])
+ ifNotNil:
+ [:definingClass|
+ self browseAllCallsOn: aVar localTo: definingClass]
+ ifNil:
+ [self browseAllCallsOn: aVar]]]!
- [ self
- browseAllAccessesTo: aVar
- from: aClass ]
- ifFalse: [ self browseAllCallsOn: aVar ] ]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220615/dc23e0cd/attachment.html>