This is how it looked before:


[cid:14414ef7-f822-4ecd-804d-deedc11b458d]

[cid:0575c315-56a9-486d-b043-f5b4ec66fe59]


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Thiede, Christoph
Gesendet: Donnerstag, 16. Juni 2022 11:33:45
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] Review Request: fix-preference-browser-overflow.1.cs

=============== Summary ===============

Change Set:        fix-preference-browser-overflow
Date:            16 June 2022
Author:            Christoph Thiede

Fixes default width of preference browser. The new preference 'RealEstateAgent windowScaleFactor' had such a long name that it did not fit into the standard width. Shorten the name and extend the initial window extent so that selecting the preference does no longer offsets all items in the list.

Note that this is only a quick-fix and might fail again once you change your screen size or fonts. In the long term, it would be nicer if we had something like StringMorph >> #maxWidth: for this (maybe even with an automatic ellipsis ...).

=============== Diff ===============

PreferenceBrowser>>initialExtent {user interface} · ct 6/16/2022 11:24 (changed)
initialExtent
    "Scale here because the receiver is not built through a tool builder. See #buildPluggableWindow:."

-     ^ (660 at 440 * RealEstateAgent scaleFactor) rounded
+     ^ (705 @ 440 * RealEstateAgent scaleFactor) rounded

RealEstateAgent class>>windowScaleFactor {preferences} · ct 6/16/2022 11:23 (changed)
- windowScaleFactor
-     <preference: 'Scale Factor for Default Extent of Tool Windows'
+ windowScaleFactor
+     <preference: 'Scale Factor for Default Window Extent'
        categoryList: #(Morphic Tools Accessibility)
-         description: 'The extent of tool windows is tweaked for a world extent of 1024 at 768 (or its scaled equivalent). If you have a larger screen available, you might want to increase a tool''s default extent. Note that you can also increase the system''s overall scale factor instead.'
+         description: 'The extent of windows is tweaked for a world extent of 1024 at 768 (or its scaled equivalent). If you have a larger screen available, you might want to increase a tool''s default extent. Note that you can also increase the system''s overall scale factor instead.'
        type: #String>
    ^ WindowScaleFactor ifNil: [1.0]

["fix-preference-browser-overflow.1.cs"]

---
Sent from Squeak Inbox Talk<https://github.com/hpi-swa-lab/squeak-inbox-talk>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220616/d0813c9b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 81307 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220616/d0813c9b/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 18845 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220616/d0813c9b/attachment-0003.png>