[squeak-dev] The Trunk: Morphic-mt.2087.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Feb 1 09:28:22 UTC 2023


Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.2087.mcz

==================== Summary ====================

Name: Morphic-mt.2087
Author: mt
Time: 1 February 2023, 10:28:20.602309 am
UUID: cce09371-2b26-b54b-b6e3-dc09e11cc469
Ancestors: Morphic-mt.2086

Harmonize filter-background color between multi-column lists and tree widgets.

=============== Diff against Morphic-mt.2086 ===============

Item was changed:
  ----- Method: IndentingListItemMorph class>>applyUserInterfaceTheme (in category 'preferences') -----
  applyUserInterfaceTheme
  
+ 	FilterBackgroundColor := PluggableMultiColumnListMorph filterColumnColor.!
- 	FilterBackgroundColor := (UserInterfaceTheme current get: #hoverSelectionModifier for: #PluggableListMorph)
- 		ifNil: [ Color white darker alpha: 0.3 ]
- 		ifNotNil: [:modifier | modifier value: ((UserInterfaceTheme current get: #color for: #ScrollPane)
- 			ifNil: [ Color white ]) ].!

Item was changed:
  ----- Method: IndentingListItemMorph class>>themePriority (in category 'preferences') -----
  themePriority
  
+ 	^ PluggableMultiColumnListMorph themePriority - 1!
- 	^ 65!

Item was changed:
  ----- Method: IndentingListItemMorph class>>themeProperties (in category 'preferences') -----
  themeProperties
  
  	^ {
+ 		{ #filterBackgroundColor. 'Styling'. 'Background color for filter matches.' }.
- 		{ #backgroundFilterColor. 'Styling'. 'Background color for filter matches.' }.
  	}!

Item was changed:
  ----- Method: IndentingListItemMorph>>applyUserInterfaceTheme (in category 'updating') -----
  applyUserInterfaceTheme
  
+ 	filterOffsets := nil.
+ 	backgroundColor ifNotNil: [backgroundColor := FilterBackgroundColor].!
- 	filterOffsets := nil.!

Item was changed:
  PluggableListMorph subclass: #PluggableMultiColumnListMorph
  	instanceVariableNames: 'listMorphs'
+ 	classVariableNames: 'FilterColumnColor'
- 	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'Morphic-Pluggable Widgets'!
  
  !PluggableMultiColumnListMorph commentStamp: '<historical>' prior: 0!
  This morph can be used to show a list having multiple columns,  The columns are self width sized to make the largest entry in each list fit.  In some cases the pane may then be too narrow.
  
  Use it like a regular PluggableListMorph except pass in an array of lists instead of a single list.
  
  There are base assumptions made here that each list in the array of lists is the same size.
  
  Also, the highlight color for the selection is easy to modify in the #highlightSelection method.  I used blue
  when testing just to see it work.!

Item was added:
+ ----- Method: PluggableMultiColumnListMorph class>>applyUserInterfaceTheme (in category 'preferences') -----
+ applyUserInterfaceTheme
+ 
+ 	FilterColumnColor := nil.!

Item was added:
+ ----- Method: PluggableMultiColumnListMorph class>>filterColumnColor (in category 'defaults') -----
+ filterColumnColor
+ 
+ 	^ FilterColumnColor ifNil: [FilterColumnColor := (self userInterfaceTheme get: #hoverSelectionModifier for: self)
+ 		ifNil: [ (Color gray: 0.85) alpha: 0.5 ]
+ 		ifNotNil: [:modifier | modifier value: ((self userInterfaceTheme get: #color for: self)
+ 			ifNil: [ Color white ])]]!

Item was added:
+ ----- Method: PluggableMultiColumnListMorph class>>themePriority (in category 'defaults') -----
+ themePriority
+ 
+ 	^ 65!

Item was added:
+ ----- Method: PluggableMultiColumnListMorph class>>themeProperties (in category 'preferences') -----
+ themeProperties
+ 
+ 	^ super themeProperties, {
+ 		{ #filterColumnColor. 'Styling'. 'Background color for filtered columns.' }.
+ 	}!

Item was changed:
  ----- Method: PluggableMultiColumnListMorph>>filterColumnColor (in category 'filtering') -----
  filterColumnColor
  
+ 	^ self class filterColumnColor!
- 	^ (Color gray: 0.85) alpha: 0.4!

Item was changed:
  ----- Method: PluggableMultiColumnListMorph>>setListParameters (in category 'initialization') -----
  setListParameters
  
  	listMorphs ifEmpty: [^ super setListParameters].
  	
+ 	listMorphs do: [:lm |
+ 		lm showFilter ifTrue: [lm backgroundColor: self filterColumnColor].
+ 		listMorph := lm. super setListParameters].
- 	listMorphs do: [:lm | listMorph := lm. super setListParameters].
  	listMorph := listMorphs first.!



More information about the Squeak-dev mailing list