<!doctype html public "-//W3C//DTD W3 HTML//EN">
<html><head><style type="text/css"><!--
blockquote, dl, ul, ol, li { padding-top: 0 ; padding-bottom: 0 }
--></style><title>[FIX] creation of a LineMorph ([sm] [cd] doubts
about</title></head><body>
<div><font size="+1" color="#000000">Before jumping into adopting this
"fix", please look at the class comment of
LineMorph.</font></div>
<div><font size="+1" color="#000000"><br></font></div>
<div><font size="+1" color="#000000">If I understand Dan's intentions
correctly, LineMorph (which adds no instance variables and has no
instance-side methods) is never intended to be instantiated; all
instantiation calls to LineMorph are *expected* to result in instances
of vanilla PolygonMorph.</font></div>
<div><br></div>
<div>Thus, Dan's use of the hard-coded "PolygonMorph" in
LineMorph class-side method #from:to:color:width: was decidedly
intentional, and the proposed "easy to understand fix"
violates that intention.</div>
<div><font size="+1" color="#000000"><br></font></div>
<div><font size="+1" color="#000000">Cheers,</font></div>
<div><font size="+1" color="#000000"><br></font></div>
<div><font size="+1" color="#000000"> -- Scott</font></div>
<div><font face="Times" size="+1" color="#000000"><br></font></div>
<div><br></div>
<blockquote type="cite" cite><font face="Times" size="+1"
color="#000000"><b>[FIX] creation of a LineMorph ([sm][cd] easy to
understand fix)</b><br>
<b>Hannes Hirzel</b></font><font face="Times" size="+1"
color="#0000FF"><u> hannes.hirzel.squeaklist at
bluewin.ch</u></font></blockquote>
<blockquote type="cite" cite><font face="Times" size="+1"
color="#000000"><i>Sat Mar 8 19:04:26 CET 2003</i></font><br>
</blockquote>
<blockquote type="cite" cite><font face="Times" size="+1"
color="#000000"
>--------------------------------------------------------------------<span
></span>----</font><br>
</blockquote>
<blockquote type="cite" cite><tt><font size="+1" color="#000000"><br>
... The only change actually done in the change set was<br>
replacing 'PolygonMorph' with 'self' in a class method.<br>
<br>
No problem. A good fix.</font></tt><br>
<tt><font size="+1" color="#000000"></font></tt></blockquote>
<blockquote type="cite" cite><tt><font size="+1" color="#000000">--
Hannes</font></tt><br>
</blockquote>
<blockquote type="cite" cite><tt><font size="+1" color="#000000"><br>
</font><font size="+1" color="#0000FF"><u>chris at
funkyobjects.org</u></font><font size="+1" color="#000000"> wrote:<br>
><i><br>
</i>><i> --==CelesteAttachment73100==<br>
</i>><i><br>
</i>><i> from preamble:<br>
</i>><i><br>
</i>><i> "Change Set:<x-tab>
</x-tab><x-tab>
</x-tab>creation of a LineMorph<br>
</i>><i> Date:<x-tab>
</x-tab><x-tab>
</x-tab><x-tab> </x-tab>23
February 2003<br>
</i>><i> Author:<x-tab>
</x-tab><x-tab>
</x-tab><x-tab>
</x-tab>Chris Muller<br>
</i>><i><br>
</i>><i> replaces a hard-coded reference to PolygonMorph with
logical class</i></font></tt></blockquote>
<blockquote type="cite" cite><tt><font size="+1"
color="#000000">><i> reference (self), allowing subclasses of
LineMorph to properly</i></font></tt></blockquote>
<blockquote type="cite" cite><tt><font size="+1"
color="#000000">><i>
instantiate."!</i></font></tt></blockquote>
<blockquote type="cite" cite><font face="Times" size="+1"
color="#000000"><br></font></blockquote>
</body>
</html>