<div dir="ltr"><div class="gmail_quote">On Fri, Sep 19, 2008 at 3:36 AM, Paolo Bonzini <span dir="ltr"><<a href="mailto:bonzini@gnu.org">bonzini@gnu.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="Ih2E3d"><br>
> object_image->image.private = options & LINK_OPTION_PRIVATE) ==<br>
> LINK_OPTION_PRIVATE;<br>
<br>
</div>Couldn't help it: if LINK_OPTION_PRIVATE is a single bit,<br>
<br>
object_image->image.private = (options & LINK_OPTION_PRIVATE) != 0;<br></blockquote></div><br><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);">You can do better than that. Even if you really need to set image.private to TRUE or FALSE explicitly, you can just do</span></div>
<div><span class="Apple-style-span" style="color: rgb(136, 136, 136);"><br></span></div><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);">object_image->image.private = !!(options & LINK_OPTION_PRIVATE)</span></div>
<div><span class="Apple-style-span" style="color: rgb(136, 136, 136);"><br></span></div><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);">and if you don't, you can drop the !!.</span></div><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);"><br>
</span></div><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);">I'd really rather just not write C though.</span></div><div><span class="Apple-style-span" style="color: rgb(136, 136, 136);"><br></span></div>
<div><span class="Apple-style-span" style="color: rgb(136, 136, 136);">--Benjamin</span></div></div>