<br><br><div class="gmail_quote">On Mon, Mar 9, 2009 at 1:23 AM, Klaus D. Witzel <span dir="ltr"><<a href="mailto:klaus.witzel@cobss.com">klaus.witzel@cobss.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Sun, 08 Mar 2009 21:46:44 +0100, Eliot Miranda wrote:<br>
<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Eliot (phone)<div class="im"><br>
<br>
On 7 Mar 2009, at 22:24, "Klaus D. Witzel" wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Sat, 07 Mar 2009 18:51:01 +0100, Eliot Miranda wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Klaus,<br>
</blockquote>
<br>
Hi Eliot,<br>
<br>
great job, native closures-support was overdue and is appreciated by the Squeakers.<br>
</blockquote>
<br>
You're so welcome! I'm looking forward to the quality of the implementation improving with wider usage. Lukas has already sent me a bug report for which we have an acceptable fix.<br>
</div></blockquote>
<br>
You may perhaps also want to check the attachment from Mantis #7311 that I created a minute ago:<br>
<br>
- <a href="http://bugs.squeak.org/view.php?id=7311" target="_blank">http://bugs.squeak.org/view.php?id=7311</a><br>
<br>
This .st has 61 tests which I've written for Marcus' NewCompiler project (testing sourceCode -> Parser -> nodes -> compiled method -> InstructionStream). Made a small change for adapting them to your passing EncoderForV3 to the parser. BTW: all green in the recent Squeak-3.10.2-Closures.image ;)</blockquote>
<div><br></div><div>Cool! But TBH let's add a little yellow:</div><div><br></div><div><div>testInlineBlockCollection1</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>| col |</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>col := OrderedCollection new.</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>1 to: 11 do: [ :each | col add: [ each ] ].</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>self assert: (col collect: [ :each | each value ]) asArray = (1 to: 11) asArray</div>
<div><br></div><div><div>testInlineBlockCollection2</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>| col |</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>col := OrderedCollection new.</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>1 to: 11 do: [ :each | | i | i := each. col add: [ i ]. i := i + 1 ].</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>self assert: (col collect: [ :each | each value ]) asArray = (2 to: 12) asArray</div>
<div><br></div></div></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">There's perhaps more to come, did a buch of tests for Igor's parser for Moebius, mainly around syntax constructs. Adapting them may need some effort+time, they depend on accurate reporting of source code position.<br>
<br>
/Klaus<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Best<br>
Eliot (mobile compromised)<br>
</blockquote><div><div></div><div class="h5">
<br>
...<br>
<br>
-- <br>
"If at first, the idea is not absurd, then there is no hope for it". Albert Einstein<br>
<br>
<br>
</div></div></blockquote></div><br>