<br><br><div class="gmail_quote">On Fri, Mar 13, 2009 at 10:04 AM, Tobias Pape <span dir="ltr"><<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hello Mariano,<br>
<br>
sorry for the late reply, I have been busy the last weeks.<br>
</blockquote><div><br>better late than never ;)<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Am 2009-03-03 um 23:08 schrieb Mariano Martinez Peck:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
</blockquote>
[…]<div class="im"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Sorry. What's what you don't understand ? I dont' understand what you didn't understand hahaaha. I give you an exampple (the firstone I found):<br>
<br>
<code><br>
executeDDLScript: aDDLScript<br>
"Its very common you need to execute a complete DDL script: create, drop or alter tables. In these cases, you don't have any interesting results from each query. In such a case, you should use this method. Remember SqueakDBX doesn't do any translation so your statement delimiter must be understood by the backend. In order to know which delimiter we use, you can see the message queryDelimiter of the current platform backend, for example DBXPostgresPlatform.<br>
This message doesn't use the multistatements option of openDBX, it is all done by SqueakDBX so you don't have to care about it''"<br>
<br>
| ddlStatements |<br>
ddlStatements := aDDLScript findTokens: self platform queryDelimiter.<br>
ddlStatements<br>
do: [:ddlStatement | self execute: ddlStatement]<br>
</code><br>
</blockquote>
<br></div>
So, now I get it. In fact, I understood your question the way, that you put empty comments<br>
into your code, as in:<br>
<br>
aMessage<br>
""<br>
<br>
self anotherMessage; aThirdMessage: true.<br>
<br>
<br>
Which would not make sense to me.<br>
Regarding your example method, in my humble opinion, this is a large methos even though<br>
it is long only due its comment. I (or wie in that case) as SwaLint developers thought that<br>
7 lines average in a class would fit smalltalk style and should cope with small getter/setters<br>
and rather lagre initializer.<br>
Well, I presume this average wouldnt fit for you, so simply change it in the preferences. In<br>
fact, it is merely a matter of taste and/or style, so don't hesitate to change if it don't fit for you.<br>
</blockquote><div><br>Ok. I will do that. <br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
[…]<div class="im"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> Ok, this might be useful. Did I got this right there? You'd like to right click on the test group and browse all of them?<br>
<br>
EXACTLY. I don't know if was just me, but actually that was my way of resolving the issues. Go test after test, and browsing for each one all the classes. Perhaps, I am the only one, so, It just doesn't worth it.<br>
</blockquote>
<br></div>
I consider it a useful feature. Yet, currently my time to work on SwaLint is fairly limitied,<br>
so please dont expect it before summer.<div class="im"><br>
</div></blockquote><div><br>I am not hurry at all :)<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
>> 4) What does "Dot after return consistency" mean ? I don't understand the % and when it is average, low or high.<br>
><br>
> Oh that's a nice one :)<br>
> This is a Style tests. It simply tests, how many returns are written<br>
><br>
> ^ anObject aMessage<br>
><br>
> and how many are written<br>
><br>
> ^ anObject aMessage.<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> Where 100% is "all with" and 0% "all without" dot after return.<br>
> Thus, 50% is the worst value you can get in this test, as it implies, that every second return statement<br>
> is written in the opposing style.<br>
<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
and are there some differences between both ways? I mean, a real difference ? or just to do it the same way in all the code ?<br>
</blockquote>
<br></div>
The latter. Its "just" about style consistency.<br>
</blockquote><div><br><br>Ok, excellent. <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Have a nice weekend,<br><font color="#888888">
-Tobias<br>
</font></blockquote><div><br>The same to you, thanks <br></div></div><br>