Is there a way to check a doit into Monticello? I am bothered somewhat by that fact that one must still:<div><br></div><div><span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; ">Preferences removePreference: #colorWhenPrettyPrinting</span></div>
<div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"><br></span></font></div><div><span class="Apple-style-span" style="font-size: 13px; "></span><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;">After updating from Trunk, otherwise the preference itself remains.</span></font></div>
<div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"><br></span></font></div><div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"> - Ron<br>
</span></font><br><div class="gmail_quote">On Sun, Aug 23, 2009 at 1:49 PM, Andreas Raab <span dir="ltr"><<a href="mailto:andreas.raab@gmx.de">andreas.raab@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
It's looking very good. Nice job!<br>
<br>
Cheers,<br>
- Andreas<br>
<br>
Ronald Spengler wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div class="h5">
Hello all,<br>
<br>
I spent some time today looking into what cruft might be left behind after sloughing colorPrint out of the system browser in favor of Shout. What I found was: somewhat tangled and messy dependencies.<br>
<br>
My main goal for the day was cleanly removing the preference #colorWhenPrettyPrinting. Note that I may have removed more than what was actually necessary, e.g., ShoutCore seems to disable the colorWhenPrettyPrinting preference on install, and I removed that line, since the preference would be gone.<br>
<br>
Methods changed:<br>
<br>
Text>>askIfAddStyle:req: (Collections)<br>
Compiler>>format:in:notifying:contentsSymbol: (Compiler)<br>
SHTextStylerST80>>initializePreferences (ShoutCore ...this is ironic...)<br>
<br>
There were a lot of changes in the System category:<br>
<br>
Preferences>><br>
colorWhenPrettyPrinting (removed)<br>
defaultValueTableForCurrentRelease<br>
smallLandPreferences<br>
<br>
SystemDictionary>><br>
testFormatter<br>
testFormatter2<br>
<br>
And yet more in tools:<br>
<br>
ChangeSorter>>setContents<br>
<br>
CodeHolder>><br>
colorPrintString (removed)<br>
contentsSymbol<br>
showingColorPrint (removed)<br>
sourceStringPrettifiedAndDiffed<br>
toggleColorPrint (removed)<br>
<br>
FileContentsBrowser>>selectedMessage<br>
<br>
The most disturbing thing that I saw on my Sunday drive was the method #format:in:notifying:contentsSymbol: in Compiler (on both class and instance sides). It looks as though the argument aSymbol is checked for equality to #colorPrint, colorizing text the old way if so, and that's the only thing it's used for. Thus, the method signature could stand to be simplified, if it weren't for the fact that this one has other senders, meaning yet more code churn; I'm hesitant to mess with the signature of a Compiler method at this point, but doing so anyway for at least the sake of experiment, I've changed:<br>
<br>
Compiler>><br>
format:in:notifying:contentsSymbol: (removed)<br>
format:in:notifying:contentsSymbol: (removed)<br>
format:in:notifying: (added)<br>
format:in:notifying: (added)<br>
<br>
In addition to applying the above, I had to do:<br>
<br>
Preferences removePreference: #colorWhenPrettyPrinting<br>
<br>
... to make the actual preference go away.<br>
<br>
So far I haven't seen anything explode yet, but this is a pretty ambitious change for me, considering that I've only been Squeaking for a little over a year.<br>
<br>
Would the good people of squeak-dev be so kind as to look over the changes I've placed in the Inbox for obvious errors? Here they are:<br>
<br>
Collections-rss.118<br>
Compiler-rss.72<br>
Tools-rss.110<br>
System-rss.134<br>
<br>
- Ron<br>
<br>
<br></div></div>
------------------------------------------------------------------------<br>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote></div><br></div>