<br><br><div class="gmail_quote">On Mon, Jan 11, 2010 at 10:43 AM, Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@elte.hu">leves@elte.hu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Sun, 10 Jan 2010, Andreas Raab wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Bert Freudenberg wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Rock!<br>
<br>
Let's watch if that fixes the next Multilingual package upload ...<br>
</blockquote>
<br>
Works all right so far, but I think we still got two problems:<br>
<br>
1) Does anyone have an idea where the double line ends come from when mailing out the diffs? It's really annoying. Any pointers to where to start looking at would be greatly welcome.<br>
<br>
2) Does anyone feel as if we're getting a higher number of connection failures than usual? It could be an issue on my end but I somehow doubt that. I seem to getting connection failures about 20% of the time when trying to update. It's quite noticable.<br>
<br>
</blockquote>
<br>
I did a bit of stress testing, by uploading a few packages one after another. There was no problem during the uploads, but when all uploads were finished it took 20-30 seconds for the server to respond for the next few 1-2 minutes. I guess it's related to the gc settings, so tweaking them may help. For a reference, here are the "seaside defaults":<br>
<br>
SmalltalkImage current<br>
vmParameterAt: 5 put: 100000;<br>
vmParameterAt: 6 put: 35000;<br>
vmParameterAt: 24 put: 16 * 1024 * 1024;<br>
vmParameterAt: 25 put: 8 * 1024 * 1024.<br></blockquote><div><br><br>Levente: were did you get this values?? What is "seaside default" ?<br><br>I see another values in my "seaside default" image.<br>
<br>Thanks<br><br>Mariano<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Smalltalk<br>
setGCBiasToGrowGCLimit: 16 * 1024 * 1024;<br>
setGCBiasToGrow: 1<br>
<br>
The uploaded changes were produced with the code critics feature of OmniBrowser. I think we should use it regularly, because it can point out issues which could be hard to find otherwise and there are plenty of issues to be fixed. They are bit broken at the moment, so running them on the whole image needs a few fixes.<br>
Some issues are easy to fix, others require deep understanding of the system.<br>
<br>
Some categories which should be fixed (number of possible issues):<br>
Messages sent but not implemented (571)<br>
Sends unknown message to global (36)<br>
Subclass responsibility not defined (82)<br>
Instance variable capitalization (4)<br>
Temporary variable capitalization (5)<br>
Inconsistent method classification (324)<br>
Non-blocks in special messages (24)<br>
Unnecessary assignment or return in block (45)<br>
Uses "(a and: [b]) and: [c]" instead of "a and: [b and: [c]]" (78)<br>
Uses (to:)do: instead of to:do: (23)<br>
Variable is only assigned a single literal value (44)<br>
Instance variable overridden by temporary variable (21)<br>
Possible missing "; yourself" (490)<br>
Returns a boolean and non boolean (42)<br>
Subclass of collection that has instance variable but doesn't define copyEmpty (1)<br>
Menus missing translations (75)<br>
Method source contains linefeeds (123)<br>
Assignment has no effect (22)<br>
Check for same statements at end of ifTrue:ifFalse: blocks (43)<br>
Instance variables not read AND written (209)<br>
Method just sends super message (17)<br>
Variable referenced in only one method and always assigned first (69)<br>
Variables not referenced (266)<br>
<br>
I hope we can decrease these numbers soon.<br>
<br>
<br>
Levente<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Cheers,<br>
- Andreas<br>
<br>
<br>
</blockquote>
<br>
</blockquote></div><br>