<br><br><div class="gmail_quote">On Mon, Mar 22, 2010 at 2:54 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
You might also want to check last code published in trunk.<br></blockquote><div><br></div><div>I saw that. You're eliminating closeTo: for float comparison which seems fine to me :) Thanks Nicolas!</div><div>However, it is indicative that a recompile all is necessary after redefining the number scanning facilities. I guess that this is part of the standard release build process. If not, we should add it.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Nicolas<br>
<br>
2010/3/22 Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>>:<br>
<div><div></div><div class="h5">><br>
><br>
> On Mon, Mar 22, 2010 at 2:25 PM, Stéphane Ducasse<br>
> <<a href="mailto:stephane.ducasse@inria.fr">stephane.ducasse@inria.fr</a>> wrote:<br>
>><br>
>> eliot<br>
>><br>
>> Your changes fixed some of the problems. Now I tried to fix the test<br>
>> testAnalogousCodeTo in MethodPropertiesTest and<br>
>> the expression returns false.<br>
>><br>
>> (#zork->'hello') analogousCodeTo: (#zork->'hello') -> false<br>
>><br>
>> (#zork->'hello') = (#zork->'hello') -> true<br>
><br>
> For me<br>
> #(#zork -> 'hello') size 3<br>
> In Pharo is it true that<br>
> #(#zork -> 'hello') size 1<br>
> ??!?!<br>
> In that case I would implement analogousCodeTo: in Association, e.g.<br>
> analogousCodeTo: anObject<br>
> ^anObject class == self class<br>
> and: [key = anObject key<br>
> and: [value = anObject value]]<br>
><br>
> But if Association isn't a literal I would simply check<br>
> MethodPropertiesTests. It could be obsolete.<br>
>><br>
>> Stef<br>
>><br>
>> On Mar 22, 2010, at 6:20 PM, Eliot Miranda wrote:<br>
>><br>
>> > Oops. Find attached.<br>
>> ><br>
>> > 2010/3/22 Cyrille Delaunay <<a href="mailto:cy.delaunay@gmail.com">cy.delaunay@gmail.com</a>><br>
>> > try in a Pharo-1.0-10515-rc3 image :<br>
>> ><br>
>> > |set|<br>
>> > set := Set new.<br>
>> > Collection withAllSubclasses do: [:aClass |<br>
>> > set addAll: aClass methods<br>
>> > ].<br>
>> ><br>
>> > It will raise an exception telling: "MessageNotUnderstood:<br>
>> > ByteSymbol>>analogousCodeTo:".<br>
>> > Indeed, in the code of CompiledMethod >> = , the message<br>
>> > 'analogousCodeTo:' is send to a<br>
>> > symbol.<br>
>> ><br>
>> ><br>
>> > I opened an Issue:<br>
>> > <a href="http://code.google.com/p/pharo/issues/detail?id=2185" target="_blank">http://code.google.com/p/pharo/issues/detail?id=2185</a><br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Pharo-project mailing list<br>
>> > <a href="mailto:Pharo-project@lists.gforge.inria.fr">Pharo-project@lists.gforge.inria.fr</a><br>
>> > <a href="http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project" target="_blank">http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project</a><br>
>> ><br>
>> ><br>
>> > <Object-analogousCodeTo.st>_______________________________________________<br>
>> > Pharo-project mailing list<br>
>> > <a href="mailto:Pharo-project@lists.gforge.inria.fr">Pharo-project@lists.gforge.inria.fr</a><br>
>> > <a href="http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project" target="_blank">http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Pharo-project mailing list<br>
>> <a href="mailto:Pharo-project@lists.gforge.inria.fr">Pharo-project@lists.gforge.inria.fr</a><br>
>> <a href="http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project" target="_blank">http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project</a><br>
><br>
><br>
> _______________________________________________<br>
> Pharo-project mailing list<br>
> <a href="mailto:Pharo-project@lists.gforge.inria.fr">Pharo-project@lists.gforge.inria.fr</a><br>
> <a href="http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project" target="_blank">http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project</a><br>
><br>
<br>
_______________________________________________<br>
Pharo-project mailing list<br>
<a href="mailto:Pharo-project@lists.gforge.inria.fr">Pharo-project@lists.gforge.inria.fr</a><br>
<a href="http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project" target="_blank">http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project</a><br>
</div></div></blockquote></div><br>