On Wed, Mar 24, 2010 at 21:17, Michael Davies <span dir="ltr"><<a href="mailto:mykdavies%2Bsqueak@gmail.com" target="_blank">mykdavies+squeak@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="gmail_quote"><div>That was a (very helpful imo) change made in the trunk to help distinguish between the
active window and others, so not an artefact of your changes. An alternative approach could be to keep them visible but desaturate them for the non-front windows.<br></div></div></blockquote><div><br>Before the menu and the full expand/contract button were just locked/disabled for non active windows. Visually the buttons didn't change, so there was no way of telling if they were active or not. They just did behave differently than the close or collapse button. All in all I thought this was very confusing. For example clicking on the menu button of an inactive window just activated that window and you had to click again to actually get the window menu in contrast on clicking on the close button, which had an immediate effect on inactive windows.<br>
<br>Why it was chosen to deactivate the menu and full expand/contract buttons on inactive windows is beyond me and might be worth for reconsideration.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="gmail_quote"><div><br>There's lots of really nice stuff in this changeset, and I really like it.<br></div></div></blockquote><div><br>That's for sure! Nice and clean.<br><br>In addition what others already said just some minor things that crossed my mind (again about the window buttons :)<br>
<br>If we are going to change the grouping of the buttons I rather would prefer to have the menu button left from window title and then following to the right collapse, full expand, close. The menu button behaves differently then the other immediate action buttons and so might be better separated from them.<br>
<br>+ and - as iconic symbols imply an inverse operation (for me), but they don't behave like that. Maybe a small box and a large box would work better for full expand/contract, also because clicking on + to contract a window feels strange.<br>
<br>Even if there is some prominent operating system doing so, I'm not a big fan of traffic light colors for window buttons. It's just distracting and the color coding won't work for me. And i think the contrast of the yellow button is to low.<br>
<br>Maybe it is fair to say, that I usually use the gnome desktop and so surely my perception is affected by that. :)<br><br>Tim, these are just little subjective things and your contribution is a major step forward.<br>
<br>
Alex<br></div></div>