I don't think I removed that method; please be aware that garbage in the inbox mangled the diff for that commit. It only contained some changes that moved items out of the world menu into the docking bar. The rest was a bad diff against something else that was left in the inbox. <div>
<br></div><div>I don't believe I removed that method; if I did, it was unintentional.<div><br></div><div>This is what I actually checked in (AFAIK)...</div><div><br></div><div><div>=============== Diff against Morphic-tfel.396 ===============</div>
<div><br></div><div>Item was changed:</div><div> ----- Method: TheWorldMenu>>buildWorldMenu (in category 'construction') -----</div><div> buildWorldMenu</div><div> "Build the menu that is put up when the screen-desktop is clicked on"</div>
<div> | menu |</div><div> menu := MenuMorph new defaultTarget: self.</div><div> menu commandKeyHandler: self.</div><div> self colorForDebugging: menu.</div><div> menu addStayUpItem.</div><div>
self makeConvenient: menu.</div><div> Smalltalk at: #ServiceGUI ifPresent:[:sgui|</div><div> sgui worldMenu: menu.</div><div> sgui onlyServices ifTrue: [^ menu].</div><div> ].</div>
<div> self addProjectEntries: menu.</div><div> myWorld addUndoItemsTo: menu.</div><div> self addRestoreDisplay: menu.</div><div> self addUtilities: menu.</div><div> self addObjectsAndTools: menu.</div>
<div> self addPrintAndDebug: menu.</div><div> self addSaveAndQuit: menu.</div><div> ^ menu!</div><div><br></div><div>Item was changed:</div><div> ----- Method: TheWorldMainDockingBar>>extrasMenuOn: (in category 'construction') -----</div>
<div> extrasMenuOn: aDockingBar</div><div><br></div><div> aDockingBar addItem: [ :it|</div><div> it contents: 'Extras' translated;</div><div> addSubMenu: [:menu|</div>
<div> menu addItem:[:item|</div><div> item</div><div> contents: 'Recover Changes' translated;</div>
<div> help: 'Recover changes after a crash' translated;</div><div> icon: MenuIcons smallHelpIcon;</div><div> target: ChangeList;</div>
<div> selector: #browseRecentLog].</div><div> menu addLine.</div><div> menu addItem:[:item|</div><div> item</div>
<div> contents: 'Window Colors' translated;</div><div> help: 'Changes the window color scheme' translated;</div><div>
addSubMenu:[:submenu| self windowColorsOn: submenu]].</div><div> menu addItem:[:item|</div><div> item</div>
<div> contents: 'Set Author Initials' translated;</div><div> help: 'Sets the author initials' translated;</div><div>
target: Utilities;</div><div> selector: #setAuthorInitials].</div><div> menu addItem:[:item|</div>
<div> item</div><div> contents: 'Restore Display (r)' translated;</div><div> help: 'Redraws the entire display' translated;</div>
<div> target: World;</div><div> selector: #restoreMorphicDisplay].</div><div> menu addItem:[:item|</div>
<div> item</div><div> contents: 'Rebuild Menus' translated;</div><div> help: 'Rebuilds the menu bar' translated;</div>
<div> target: TheWorldMainDockingBar;</div><div> selector: #updateInstances].</div><div> menu addLine.</div>
<div> menu addItem:[:item|</div><div> item</div><div> contents: 'Start Profiler' translated;</div><div>
help: 'Starts the profiler' translated;</div><div> target: self;</div><div> selector: #startMessageTally].</div>
<div> menu addItem:[:item|</div><div> item</div><div> contents: 'Collect Garbage' translated;</div>
<div> help: 'Run the garbage collector and report space usage' translated;</div><div> target: Utilities;</div><div> selector: #garbageCollectAndReport].</div>
<div> menu addItem:[:item|</div><div> item</div><div>+ contents: 'Purge Undo Records' translated;</div>
<div>+ help: 'Save space by removing all the undo information remembered in all projects' translated;</div><div>+ target: CommandHistory;</div>
<div>+ selector: #resetAllHistory].</div><div>+ menu addItem:[:item|</div><div>+ item</div><div> contents: 'VM statistics' translated;</div>
<div> help: 'Virtual Machine information' translated;</div><div> target: self;</div><div> selector: #vmStatistics].</div>
<div>+ menu addLine.</div><div>+ menu addItem:[:item|</div><div>+ item</div><div>+ contents: 'Graphical Imports' translated;</div>
<div>+ help: 'View the global repository called ImageImports; you can easily import external graphics into ImageImports via the FileList' translated;</div><div>+ target: (Imports default);</div>
<div>+ selector: #viewImages].</div><div>+ menu addItem:[:item|</div><div>+ item</div><div>+ contents: 'Standard Graphics Library' translated;</div>
<div>+ help: 'Lets you view and change the system''s standard library of graphics' translated;</div><div>+ target: ScriptingSystem;</div>
<div>+ selector: #inspectFormDictionary].</div><div>+ menu addItem:[:item|</div><div>+ item</div><div>+ contents: 'Annotation Setup' translated;</div>
<div>+ help: 'Click here to get a little window that will allow you to specify which types of annotations, in which order, you wish to see in the annotation panes of browsers and other tools' translated;</div>
<div>+ target: Preferences;</div><div>+ selector: #editAnnotations].</div><div> ] ]!</div><div><br></div><div>
Item was changed:</div><div> ----- Method: TheWorldMenu>>addUtilities: (in category 'construction') -----</div><div> addUtilities: menu</div><div> Preferences simpleMenus ifFalse: [</div><div> self</div>
<div> fillIn: menu</div><div> from: {</div><div> { 'open...'. { self. #openWindow } }.</div><div> { 'windows...'. { self. #windowsDo } }.</div>
<div> { 'changes...'. { self. #changesDo } }</div><div> } ].</div><div> self</div><div> fillIn: menu</div><div> from: {</div><div>
+ " { 'help...'. { self. #helpDo }. 'puts up a menu of useful items for updating the system, determining what version you are running, and much else' }."</div><div>- { 'help...'. { self. #helpDo }. 'puts up a menu of useful items for updating the system, determining what version you are running, and much else' }.</div>
<div> { 'appearance...'. { self. #appearanceDo }. 'put up a menu offering many controls over appearance.' }</div><div> }.</div><div> Preferences simpleMenus ifFalse: [</div>
<div> self</div><div> fillIn: menu</div><div> from: {</div><div> { 'do...'. { Utilities. #offerCommonRequests }. 'put up an editible list of convenient expressions, and evaluate the one selected.' }</div>
<div> } ]!</div><div><br></div><div>Item was changed:</div><div> ----- Method: TheWorldMainDockingBar>>helpMenuOn: (in category 'construction') -----</div><div> helpMenuOn: aDockingBar</div>
<div><br></div><div> aDockingBar addItem: [ :it |</div><div> it contents: 'Help' translated;</div><div> addSubMenu: [ :menu | 'Todo'.</div><div> menu addItem:[:item|</div>
<div> item</div><div> contents: 'Online Resources' translated;</div><div> help: 'Online resources for Squeak' translated;</div>
<div> target: self;</div><div> selector: #showSqueakResources ].</div><div> menu addItem:[:item|</div>
<div> item</div><div> contents: 'Keyboard Shortcuts' translated;</div><div> help: 'Keyboard bindings used in Squeak' translated;</div>
<div> target: Utilities;</div><div> selector: #openCommandKeyHelp ].</div><div>+ menu addItem:[:item|</div>
<div>+ item</div><div>+ contents: 'Font Size Summary' translated;</div><div>+ help: 'Font size summary from the old Squeak 3.10.2 help menu.' translated;</div>
<div>+ target: TextStyle;</div><div>+ selector: #fontSizeSummary ].</div><div>+ menu addItem:[:item|</div>
<div>+ item</div><div>+ contents: 'Useful Expressions' translated;</div><div>+ help: 'Useful expressions from the old Squeak 3.10.2 help menu.' translated;</div>
<div>+ target: Utilities;</div><div>+ selector: #openStandardWorkspace ].</div><div> ]].!</div><div><br></div>
<div>Item was changed:</div><div> ----- Method: TheWorldMenu>>addObjectsAndTools: (in category 'construction') -----</div><div> addObjectsAndTools: menu</div><div> self</div><div> fillIn: menu</div>
<div> from: {</div><div> nil.</div><div> { 'objects (o)'. { #myWorld. #activateObjectsTool }. 'A tool for finding and obtaining many kinds of objects' }.</div>
<div> { 'new morph...'. { self. #newMorph }. 'Offers a variety of ways to create new objects' }.</div><div> nil.</div><div> { 'authoring tools...'. { self. #scriptingDo }. 'A menu of choices useful for authoring' }.</div>
<div> { 'playfield options...'. { self. #playfieldDo }. 'A menu of options pertaining to this object as viewed as a playfield' }.</div><div> { 'flaps...'. { self. #flapsDo }. 'A menu relating to use of flaps. For best results, use "keep this menu up"' }.</div>
<div> { 'projects...'. { self. #projectDo }. 'A menu of commands relating to use of projects' }.</div><div>+ { 'telemorphic...' . {self. #remoteDo}. 'commands for doing multi-machine "telemorphic" experiments'}.</div>
<div> nil</div><div> }!</div><div><br></div>
<br><div class="gmail_quote">On Sat, Apr 3, 2010 at 1:22 PM, glenpaling <span dir="ltr"><<a href="mailto:glenpaling@rogers.com" target="_blank">glenpaling@rogers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Removal of morphicStartUpWithCaption:icon:at:allowKeyboard: from PopUpMenu<br>
breaks StandardFileMenu (try: StandardFileMenu oldFile). Perhaps you<br>
removed it because it has no senders. That's because the selector is created<br>
from the concatenation of 'morphic' and<br>
startUpWithCaption:icon:at:allowKeyboard in Project (see below). It was<br>
recently added by David T. Lewis to manage Morphic and MVC compatibility.<br>
<br>
dispatchTo: requestor addPrefixAndSend: baseSelector withArguments:<br>
arguments<br>
"Sender wants to perform a method with dependencies on the type of project.<br>
Dispatch to an appropriate method for the current project.<br>
<br>
This method is a workaround for lack of proper ToolBuilder support in the<br>
sender,<br>
and should be eliminated when possible (dtl Feb 2010)"<br>
<br>
| selector |<br>
"Flag target selectors to help identify senders"<br>
self flag: #mvcOpenLabel:in: .<br>
self flag: #morphicOpenLabel:in: .<br>
self flag: #mvcStartUpLeftFlush .<br>
self flag: #morphicStartUpLeftFlush .<br>
self flag: #mvcStartUpWithCaption:icon:at:allowKeyboard: .<br>
self flag: #morphicStartUpWithCaption:icon:at:allowKeyboard: .<br>
self flag: #mvcOpen: .<br>
self flag: #morphicOpen: .<br>
self flag: #mvcOpen .<br>
self flag: #morphicOpen .<br>
<br>
selector := (self selectorPrefixForDispatch, baseSelector) asSymbol.<br>
^ requestor perform: selector withArguments: argumentsglenpaling@...<br>
commits-2 wrote:<br>
><br>
> A new version of Morphic was added to project The Inbox:<br>
> <a href="http://source.squeak.org/inbox/Morphic-cbr.392.mcz" target="_blank">http://source.squeak.org/inbox/Morphic-cbr.392.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Morphic-cbr.392<br>
> Author: cbr<br>
> Time: 26 March 2010, 1:38:37.423 am<br>
> UUID: d2ec5332-d31e-40e5-a5b4-f896cea50f20<br>
> Ancestors: Morphic-mha.391<br>
><br>
> I find it irksome that we have two help menus (one in the main docking<br>
> bar, one in the world menu.) I also find it irksome that there's so much<br>
> stuff in the help menu that's in the world menu that's not really<br>
> help-related.<br>
><br>
> I moved the stuff that's actually help (except for "world menu help" which<br>
> really isn't that helpful) out of the world menu and into the docking bar.<br>
> I took everything else that wasn't already exposed somewhere and put it in<br>
> the Extras menu on the docking bar.<br>
><br>
> I moved telemorphic up to the top of the world menu because I don't know<br>
> what it's for, because it pops a submenu that wants self to be an instance<br>
> of TheWorldMenu, and because I didn't really care to mess with<br>
> transplanting it.<br>
><br>
> BIG snip<br>
><br>
> Item was removed:<br>
> - ----- Method:<br>
> PopUpMenu>>morphicStartUpWithCaption:icon:at:allowKeyboard: (in category<br>
> '*Morphic-Menus') -----<br>
> - morphicStartUpWithCaption: captionOrNil icon: aForm at: location<br>
> allowKeyboard: aBoolean<br>
> - "Display the menu, with caption if supplied. Wait for the mouse button<br>
> to go down, then track the selection as long as the button is pressed.<br>
> When the button is released,<br>
> - Answer the index of the current selection, or zero if the mouse is not<br>
> released over any menu item. Location specifies the desired topLeft of<br>
> the menu body rectangle. The final argument indicates whether the menu<br>
> should seize the keyboard focus in order to allow the user to navigate it<br>
> via the keyboard."<br>
> -<br>
> - selection := Cursor normal<br>
> - showWhile: [| menuMorph |<br>
> - menuMorph := MVCMenuMorph from: self title: nil.<br>
> - (captionOrNil notNil<br>
> - or: [aForm notNil])<br>
> - ifTrue: [menuMorph addTitle: captionOrNil icon: aForm].<br>
> - MenuIcons decorateMenu: menuMorph.<br>
> - menuMorph<br>
> - invokeAt: location<br>
> - in: ActiveWorld<br>
> - allowKeyboard: aBoolean].<br>
> - ^ selection!<br>
><br>
><br>
><br>
><br>
<font color="#888888">--<br>
View this message in context: <a href="http://n4.nabble.com/The-Inbox-Morphic-cbr-392-mcz-tp1691850p1750456.html" target="_blank">http://n4.nabble.com/The-Inbox-Morphic-cbr-392-mcz-tp1691850p1750456.html</a><br>
Sent from the Squeak - Dev mailing list archive at Nabble.com.<br>
<br>
</font></blockquote></div><br>
</div></div>