Hi Frank,<div><br></div><div> the problem with the below is that no reasons as to the failures are included. If you look at the cases I added you'll see I commented each case with the reason for the failure. We need this so we can see which failures are inevitable, because of acceptable limitations in the Decompiler we have to tolerate, and which failures are real Decompiler bugs.</div>
<div><br></div><div>e.g.<br><br></div><div><span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; "> (BalloonEngineSimulation circleCosTable "-0.3826834323650903 => -0.38268343236509 or -0.3826834323650902")</span></div>
<div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"> <span class="Apple-style-span" style="font-size: 13px; ">(TShaderProgram vertexStrings) "foo ifTrue: []. => foo. => ."</span></span></font></div>
<div><span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; "> (TWindow zoomWindow:) "foo ifTrue: [^bar] ifFalse: [^baz]. ^huh?"</span></div><div><span class="Apple-style-span" style="font-size: 13px; "></span><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"><br>
</span></font><div class="gmail_quote">On Mon, Apr 5, 2010 at 1:37 PM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
A new version of Tests was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Tests-fbs.68.mcz" target="_blank">http://source.squeak.org/inbox/Tests-fbs.68.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-fbs.68<br>
Author: fbs<br>
Time: 5 April 2010, 10:37:01.668 pm<br>
UUID: a81ca190-845c-c744-8438-ddccf33d729a<br>
Ancestors: Tests-ar.67<br>
<br>
Update DecompilerTests>>decompilerFailures with all the failing tests in the #testDecompilerInClasses<Foo>to<Bar> tests.<br>
<br>
Where syntax errors occur, I've noted the error given. In one case (towards the end of the run, so perhaps a class starting with a P or an S?) I missed noting an "out of scope" error.<br>
<br>
=============== Diff against Tests-ar.67 ===============<br>
<br>
Item was changed:<br>
----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') -----<br>
decompilerFailures<br>
"here is the list of failures: DNU resulting in trying to decompile the following methods"<br>
<br>
+ ^ #((AdditionalMethodState at:ifAbsent:)<br>
+ (AdditionalMethodState at:ifAbsentPut:)<br>
+ (AdditionalMethodState at:put:)<br>
+ (AdditionalMethodState hasLiteralSuchThat:)<br>
+ (AdditionalMethodState hasLiteralThorough:)<br>
+ (AdditionalMethodState includesProperty:)<br>
+ (AdditionalMethodState keysAndValuesDo:)<br>
+ (AdditionalMethodState pragmas)<br>
+ (AdditionalMethodState properties)<br>
+ (AdditionalMethodState propertyKeysAndValuesDo:)<br>
+ (AdditionalMethodState propertyValueAt:ifAbsent:)<br>
+ (AdditionalMethodState removeKey:ifAbsent:)<br>
+ (AdditionalMethodState setMethod:)<br>
+ (BalloonEngineSimulation circleCosTable "-0.3826834323650903 => -0.38268343236509 or -0.3826834323650902")<br>
- ^ #((BalloonEngineSimulation circleCosTable "-0.3826834323650903 => -0.38268343236509 or -0.3826834323650902")<br>
(BalloonEngineSimulation circleSinTable "-0.3826834323650903 => -0.38268343236509 or -0.3826834323650902")<br>
+ (BlockNode emitCodeExceptLast:encoder:)<br>
+ (BlockNode sizeCodeExceptLast:)<br>
+ (Categorizer changeFromCategorySpecs:)<br>
+ (Categorizer elementCategoryDict)<br>
+ (ChatNotes storeAIFFOnFile:)<br>
+ (ClosureTests testToDoInsideTemp)<br>
+ (Command veryDeepFixupWith:)<br>
+ (CompiledMethod =)<br>
+ (CompiledMethod allEmbeddedBlockMethods)<br>
+ (CompiledMethod embeddedBlockMethods)<br>
+ (CompiledMethod getPreambleFrom:at:)<br>
+ (CompiledMethod hasLiteralSuchThat:)<br>
+ (CompiledMethod hasLiteralThorough:)<br>
+ (CompiledMethod sameTraitCodeAs:)<br>
+ (Date printOn:)<br>
+ (DependencyBrowser computePackageDependencies:)<br>
+ (EventSensor eventTickler)<br>
+ (Float printPaddedWith:to:)<br>
+ (FMSound mixSampleCount:into:startingAt:leftVol:rightVol:)<br>
+ (Form preMultiplyAlpha)<br>
+ (FTPClient getDataInto:)<br>
(GeniePlugin primSameClassAbsoluteStrokeDistanceMyPoints:otherPoints:myVectors:otherVectors:mySquaredLengths:otherSquaredLengths:myAngles:otherAngles:maxSizeAndReferenceFlag:rowBase:rowInsertRemove:rowInsertRemoveCount: "Cannot compile -- stack including temps is too deep")<br>
+ (GZipReadStream on:from:to:)<br>
+ (GraphMorph drawDataOn:)<br>
+ (HttpUrl checkAuthorization:retry:)<br>
+ (Integer asBytesDescription)<br>
+ (IntegerTest testNumberOfDigits)<br>
+ (IntegerTest testPrintStringBase)<br>
+ (JPEGReadWriter decodeBlockInto:component:dcTable:acTable:)<br>
+ (LoopedSampledSound mixSampleCount:into:startingAt:leftVol:rightVol:)<br>
+ (MessageTally treePrintOn:tabs:thisTab:total:totalTime:tallyExact:orThreshold:)<br>
+ (MessageTrace selectAllBetweenAnchorAnd:)<br>
+ (MethodPragmaTest testCompileCharacter)<br>
+ (MultiByteBinaryOrTextStream next:)<br>
+ (MultiByteFileStream next:)<br>
+ (MVCProject textWindows)<br>
+ (MVCToolBuilder setLayout:in:)<br>
+ (NewParagraph selectionRectsFrom:to:)<br>
+ (OldSocket getResponseNoLF)<br>
+ (PackageDependencyTest testPackage:dependsExactlyOn:)<br>
+ (PasteUpMorph dropFiles:)<br>
+ (Player veryDeepFixupWith:)<br>
+ (PluggableTabButtonMorph calculateArcLengths)<br>
+ (PluggableTabButtonMorph drawTabOn:)<br>
+ (PluckedSound reset)<br>
+ (PNGReadWriter copyPixelsGray:)<br>
+ (PNGReadWriter processInterlaced)<br>
+ (PNMReadWriter nextPutRGB:)<br>
+ (PNMReadWriter nextPutBW:reverse:)<br>
+ (PNMReadWriter readBWreverse:)<br>
+ (PNMReadWriter readGray)<br>
+ (PNMReadWriter readPlainRGB)<br>
+ (PNMReadWriter writeHeader:)<br>
+ (PointTest testTheta)<br>
+ (PopUpMenu readKeyboard)<br>
+ (PostscriptCanvas outlineQuadraticBezierShape:)<br>
(QPickable2D pick:) "foo ifTrue: [^bar] ifFalse: [^baz]. ^huh?"<br>
(QUsersPane userEntryCompare:to:) "foo ifTrue: [^bar] ifFalse: [^baz]. ^huh?"<br>
+ (RelativeInstructionPrinter print:)<br>
+ (RemoteHandMorph appendNewDataToReceiveBuffer)<br>
+ (ScaledDecimalTest testConvertFromFraction)<br>
+ (SHMCClassDefinition allInstVarNames)<br>
+ (SHMCClassDefinition withAllSuperclasses)<br>
+ (ShortIntegerArray writeOn:)<br>
+ (SHParserST80 isBinary)<br>
+ (StandardScriptingSystem holderWithAlphabet)<br>
+ (StrikeFontSet displayStringR2L:on:from:to:at:kern:)<br>
+ (String howManyMatch:)<br>
+ (String keywords)<br>
+ (StringTest testWthNoLineLongerThan)<br>
+ (SyntaxMorph replaceKeyWord:menuItem:)<br>
+ (SyntaxMorph replaceSel:menuItem:)<br>
+ (TextDiffBuilder lcsFor:and:)<br>
+ (TextURL actOnClickFor:)<br>
(TShaderProgram vertexStrings) "foo ifTrue: []. => foo. => ."<br>
(TShaderProgram fragmentStrings) "foo ifTrue: []. => foo. => ."<br>
+ (TTContourConstruction segmentsDo:) "out of scope variable"<br>
+ (TTCFontReader processCharacterMappingTable:)<br>
+ (TTFileDescription getGlyphFlagsFrom:size:)<br>
+ (TTFileDescription processCharacterMappingTable:)<br>
+ (TTFontReader getGlyphFlagsFrom:size:)<br>
+ (TTFontReader processCharacterMappingTable:)<br>
+ (TTFontReader processHorizontalMetricsTable:length:)<br>
(TWindow zoomWindow:) "foo ifTrue: [^bar] ifFalse: [^baz]. ^huh?"<br>
+ (WaveEditor showEnvelope)<br>
+ (WeakSet scanForLoadedSymbol:)<br>
<br>
"(PNMReadWriter nextImage) (Collection #ifEmpty:ifNotEmpty:) (Collection #ifEmpty:) (Collection #ifNotEmpty:ifEmpty:) (Text #alignmentAt:ifAbsent:) (ObjectWithDocumentation propertyAt:ifAbsent:)")!<br>
<br>
<br>
</blockquote></div><br></div>