Hi David,<br><br><div class="gmail_quote">On Tue, May 18, 2010 at 4:33 PM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Tue, May 18, 2010 at 02:17:40PM -0700, Eliot Miranda wrote:<br>
> Hi Hans-Martin,<br>
><br>
> On Tue, May 18, 2010 at 12:15 PM, Hans-Martin Mosner <<a href="mailto:hmm@heeg.de">hmm@heeg.de</a>> wrote:<br>
><br>
> > Hello,<br>
> > while looking at the decompiled code of some OMeta methods I noticed<br>
> > that the temp name handling in the decompiler seems to be broken.<br>
> > When you compile a method with temps that are referenced from blocks,<br>
> > the decompiler tends to rearrange the temp names, so this method<br>
> ><br>
> > test<br>
> > | one two |<br>
> > two := 2.<br>
> > ^{[one := 1].<br>
> > [ [one + two] value]}<br>
> ><br>
> > gets decompiled to this:<br>
> ><br>
> > test<br>
> > | one two |<br>
> > one := 2.<br>
> > ^ {[two := 1]. [[two + one] value]}<br>
> ><br>
><br>
> OK, the issue in Squeak 4.1 is that the<br>
> CodeHolder>>decompiledSourceIntoContents method is out of date. Find<br>
> attached.<br>
<br>
</div>I tried the Decompiler.1.cs patch in Squeak trunk, and it produces some undesirable<br>
side effects. Here is what I did:<br>
<br>
- saved a copy of changes file<br>
- created a new method in a browser<br>
- save and exit<br>
- copy saved changes file back to changes file (to eliminate the source for new method)<br>
- restart image<br>
- decompiled code in browser shows bug reported by Hans-Martin Mosner<br>
- loaded Decompiler.1.cs<br>
- decompiled code in browser produces a "Note:" dialog, and the following<br>
(garbage) in the codeholder window:<br>
<br>
"ueak/Squeak3.10-dev/squeak.10.image"<br></blockquote><div><br></div><div>that's a different issue caused by your effectively truncating the changes file. What you've done is arrange that the method's source pointer points into the SNAPSHOT marker in the original changes file. What you need to do is select decompile from the source button dropdown menu in the browser, not switch the changes file underneath the method and expect the system to automatically figure out that the source is corrupt and it should decompile.</div>
<div><br></div><div>cheers</div><div>Eliot</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Dave<br>
<br>
<br>
</blockquote></div><br>