<br><br><div class="gmail_quote">On Mon, Sep 6, 2010 at 11:30 PM, Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@elte.hu">leves@elte.hu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Sun, 5 Sep 2010, Rob Withers wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I did some rework so that all plugins build on Cog. This mainly entailed pulling MD5Plugin from a previous version and renaming several methods implemented with the same name in MD5Plugin and SHA256Plugin. The version is<br>
</blockquote>
<br></div>
What was the point of renaming those methods? In MD5Plugin those methods are generated as the category and the method comment states. So renaming them without changing the code that generates those methods is not a good idea.<br>
Also the codegenerator should be updated a bit. It should generate code for both litte- and big-endian machines and the C compiler should decide which method to use based on the platform, so the C code can be shared.<br>
The current code in the package is generated for 32-bit little-endian machines (it may work for 64-bit but that has to be checked).<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
the latest with 'oscog' as the initials.<br>
</blockquote>
<br></div>
I think that the plugin code (Smalltalk) should be the same for SqueakVM and CogVM, using the non-pragma declarations.<br></blockquote><div><br></div><div>I agree that they should be the same but feel they should /use/ the pragma declarations. We can easily post the pragma declarations support into the standard Slang (we should merge Cog's and the standard) and as discussed a few weeks ago there really isn't a compelling argument that says one needs to be able to run VMMaker in old versions. That's quite a different statement to saying it's not useful to support older VMs; it is. But the VM definition code doesn't need to be backwards-compatible, unless we want to be truly shackled.</div>
<div><br></div><div>best</div><div>Eliot</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><font color="#888888">
<br>
<br>
Levente</font><div><div></div><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
All test pass GREEN.<br>
<br>
Rob <br>
<br>
</blockquote>
<br>
</div></div></blockquote></div><br>