<br><br><div class="gmail_quote">On Thu, Sep 9, 2010 at 9:21 AM, Bert Freudenberg <span dir="ltr"><<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 09.09.2010, at 17:58, Andreas Raab wrote:<br>
<br>
> I really like this but I am wondering: Why are the changes only listed as a reminder and not kept in the checkin comment? One of the biggest difficulties that I often have is finding out where exactly a method got modified in the history of some package which is exactly what's provided here. It also gives a scope for how sweeping the changes in a particular package versions were.<br>
><br>
> So I vote for leaving the information in the checkin comment.<br>
><br>
> Cheers,<br>
> - Andreas<br>
<br>
<br>
</div>Well, that's how other SCM handle it, and where I got the idea from. The comment should be written and not be generated, I think.<br>
<br>
E.g. when I look at a package's version history on squeaksource, I'd hate having to see the modified methods all the time. Maybe we need a "-v" button ;)<br>
<br>
Listing the difference between two versions should really be a separate operation IMHO and not be part of the comment (where it would also be unreliable). We lack UI for that, true, but I'd rather wait for that than cluttering the comments now, which we can't undo later.<br>
<br>
I wouldn't mind storing the modifications as a separate field in MCVersionInfo as much, although the version history already takes up quite a chunk of space in an MCZ package. Making it even larger is not a good idea imho.<br>
</blockquote><div><br></div><div>[I feel like Vizini this a.m.]</div><div><br></div><div>For me being able to find out in what version a method changed would be very valuable, so like Andreas I would like the changes in the version history.</div>
<div>But for me being able to upload and download packages quickly is vey important, so like Bert I would not like the changes in the version history.</div><div>Since we know that currently the version history does not include method change history we know that adding the info at this stage would not yield benefits for a long time.</div>
<div>But if we wrote an offline tool we could collect that version history from existing and future package files and put it in a parallel file to each package file with a different extension to mcz and if that file behaved sufficiently like an mcz then the versions browser could show it.</div>
<div><br></div><div>Time to take some Iocane powder.</div><div><br></div><div>2¢</div><div>Eliot</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
- Bert -<br>
</font><div><div></div><div class="h5"><br>
> On 9/7/2010 7:29 PM, <a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a> wrote:<br>
>> Bert Freudenberg uploaded a new version of Monticello to project The Trunk:<br>
>> <a href="http://source.squeak.org/trunk/Monticello-bf.399.mcz" target="_blank">http://source.squeak.org/trunk/Monticello-bf.399.mcz</a><br>
>><br>
>> ==================== Summary ====================<br>
>><br>
>> Name: Monticello-bf.399<br>
>> Author: bf<br>
>> Time: 4 September 2010, 7:06:03.314 pm<br>
>> UUID: d34224f4-a77d-44ec-9981-4a9e6fec5d29<br>
>> Ancestors: Monticello-ar.398<br>
>><br>
>> When saving a package, the changes about to be committed are listed as a reminder.<br>
>><br>
><br>
<br>
<br>
</div></div></blockquote></div><br>