Hi Ken,<div><br></div><div>    please go ahead and delete; thanks.</div><div><br></div><div>best</div><div>Eliot</div><div><br></div><div><br><br><div class="gmail_quote">On Mon, Oct 11, 2010 at 1:15 PM, Ken Causey <span dir="ltr">&lt;<a href="mailto:ken@kencausey.com">ken@kencausey.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I was poised to delete the package version and then saw this query from<br>
Levente.  I&#39;ll hold off until I&#39;ve heard from Eliot to confirm he wants<br>
it deleted.<br>
<font color="#888888"><br>
Ken<br>
</font><div><div></div><div class="h5"><br>
On Mon, 2010-10-11 at 21:21 +0200, Levente Uzonyi wrote:<br>
&gt; On Mon, 11 Oct 2010, Eliot Miranda wrote:<br>
&gt;<br>
&gt; &gt; Argh!  This went to the wrong repository.  Can someone with admin privileges<br>
&gt; &gt; on <a href="http://source.squeak.org" target="_blank">source.squeak.org</a> delete this?<br>
&gt;<br>
&gt; Why? Are these changes private? Fixing the highlighting of the new<br>
&gt; primitive pragmas is on my todo list, and these changes seem to be fixing<br>
&gt; them.<br>
&gt;<br>
&gt;<br>
&gt; Levente<br>
&gt;<br>
&gt; &gt;<br>
&gt; &gt; TIA<br>
&gt; &gt; Eliot<br>
&gt; &gt;<br>
&gt; &gt; On Mon, Oct 11, 2010 at 11:37 AM, &lt;<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>&gt; wrote:<br>
&gt; &gt;<br>
&gt; &gt;&gt; Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:<br>
&gt; &gt;&gt; <a href="http://source.squeak.org/trunk/ShoutCore-eem.22.mcz" target="_blank">http://source.squeak.org/trunk/ShoutCore-eem.22.mcz</a><br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; ==================== Summary ====================<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Name: ShoutCore-eem.22<br>
&gt; &gt;&gt; Author: eem<br>
&gt; &gt;&gt; Time: 11 October 2010, 11:37:36.994 am<br>
&gt; &gt;&gt; UUID: bf5e644e-451b-4117-bb1a-8d3a087f902d<br>
&gt; &gt;&gt; Ancestors: ShoutCore-eem.16, ShoutCore-nice.21<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Merge with ShoutCore-nice.21.<br>
&gt; &gt;&gt; Now that we now that $- is (almost) a normal binary selector character (it<br>
&gt; &gt;&gt; also occurs in Number literals), let&#39;s do more simplifications.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Laza&#39;s isNil ifTrue:... =&gt; ifNil: tweaks.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; =============== Diff against ShoutCore-nice.21 ===============<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Item was changed:<br>
&gt; &gt;&gt;  ----- Method: SHParserST80&gt;&gt;parseExternalCall (in category &#39;parse&#39;) -----<br>
&gt; &gt;&gt;  parseExternalCall<br>
&gt; &gt;&gt; +       [self scanNext.<br>
&gt; &gt;&gt; +       ((Smalltalk at: #ExternalFunction) callingConventionModifierFor:<br>
&gt; &gt;&gt; currentToken) notNil]<br>
&gt; &gt;&gt; +               whileTrue.<br>
&gt; &gt;&gt; -       self scanNext.<br>
&gt; &gt;&gt;        self scanPast: #externalCallType.<br>
&gt; &gt;&gt;        currentToken = &#39;*&#39;<br>
&gt; &gt;&gt;                ifTrue: [self scanPast: #externalCallTypePointerIndicator].<br>
&gt; &gt;&gt;        currentTokenFirst isDigit<br>
&gt; &gt;&gt;                ifTrue: [self scanPast: #integer]<br>
&gt; &gt;&gt;                ifFalse:        [<br>
&gt; &gt;&gt;                        self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt;                        self parseString].<br>
&gt; &gt;&gt;        self failUnless: currentTokenFirst == $(.<br>
&gt; &gt;&gt;        self scanPast: #leftParenthesis.<br>
&gt; &gt;&gt; +       [currentTokenFirst ~= $)]<br>
&gt; &gt;&gt; -       [currentTokenFirst ~~ $)]<br>
&gt; &gt;&gt;                whileTrue: [<br>
&gt; &gt;&gt;                        self scanPast: #externalCallType.<br>
&gt; &gt;&gt;                        currentToken = &#39;*&#39;<br>
&gt; &gt;&gt;                                ifTrue: [self scanPast:<br>
&gt; &gt;&gt; #externalCallTypePointerIndicator]].<br>
&gt; &gt;&gt;        self scanPast: #rightParenthesis.<br>
&gt; &gt;&gt;        currentToken = &#39;module:&#39;<br>
&gt; &gt;&gt;                ifTrue: [<br>
&gt; &gt;&gt;                        self scanPast: #module.<br>
&gt; &gt;&gt;                        self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt;                        self parseString].<br>
&gt; &gt;&gt; +       currentToken = &#39;error:&#39;<br>
&gt; &gt;&gt; +               ifTrue: [<br>
&gt; &gt;&gt; +                       self scanPast: #module.<br>
&gt; &gt;&gt; +                       currentTokenFirst == $&#39;<br>
&gt; &gt;&gt; +                               ifTrue: [self parseString]<br>
&gt; &gt;&gt; +                               ifFalse: [self scanPast: #patternTempVar]].<br>
&gt; &gt;&gt;        self failUnless: currentToken = &#39;&gt;&#39;.<br>
&gt; &gt;&gt;        self scanPast: #primitiveOrExternalCallEnd!<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Item was changed:<br>
&gt; &gt;&gt;  ----- Method: SHParserST80&gt;&gt;parsePrimitive (in category &#39;parse&#39;) -----<br>
&gt; &gt;&gt;  parsePrimitive<br>
&gt; &gt;&gt; +       | numericPrim yetToSeeErrorCode |<br>
&gt; &gt;&gt; +       yetToSeeErrorCode := true.<br>
&gt; &gt;&gt;        self scanNext.<br>
&gt; &gt;&gt; +       (numericPrim := currentTokenFirst isDigit)<br>
&gt; &gt;&gt; -       currentTokenFirst isDigit<br>
&gt; &gt;&gt;                ifTrue: [self scanPast: #integer]<br>
&gt; &gt;&gt;                ifFalse: [<br>
&gt; &gt;&gt; +                       self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt; +                       self parseString].<br>
&gt; &gt;&gt; +       currentToken = &#39;error:&#39; ifTrue:<br>
&gt; &gt;&gt; +               [yetToSeeErrorCode := false.<br>
&gt; &gt;&gt; +                self scanPast: #primitive.<br>
&gt; &gt;&gt; +                self isName<br>
&gt; &gt;&gt; +                       ifTrue: [self scanPast: #patternTempVar]<br>
&gt; &gt;&gt; +                       ifFalse:<br>
&gt; &gt;&gt; +                               [self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt; +                                self parseString]].<br>
&gt; &gt;&gt; +       numericPrim ifFalse:<br>
&gt; &gt;&gt; +               [currentToken = &#39;module:&#39; ifTrue:<br>
&gt; &gt;&gt; +                       [self scanPast: #module.<br>
&gt; &gt;&gt; +                        self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt; +                        self parseString]].<br>
&gt; &gt;&gt; +       (yetToSeeErrorCode<br>
&gt; &gt;&gt; +        and: [currentToken = &#39;error:&#39;]) ifTrue:<br>
&gt; &gt;&gt; +               [self scanPast: #primitive.<br>
&gt; &gt;&gt; +                self isName<br>
&gt; &gt;&gt; +                       ifTrue: [self scanPast: #patternTempVar]<br>
&gt; &gt;&gt; +                       ifFalse:<br>
&gt; &gt;&gt; +                               [self failUnless: currentTokenFirst == $&#39;.<br>
&gt; &gt;&gt; +                                self parseString]].<br>
&gt; &gt;&gt; +       self failUnless: currentToken = &#39;&gt;&#39;.<br>
&gt; &gt;&gt; -                       currentTokenFirst == $&#39;<br>
&gt; &gt;&gt; -                               ifTrue: [ self parseString ]<br>
&gt; &gt;&gt; -                               ifFalse: [<br>
&gt; &gt;&gt; -                                       currentTokenFirst == $#<br>
&gt; &gt;&gt; -                                               ifTrue: [ self parseSymbol<br>
&gt; &gt;&gt; ]<br>
&gt; &gt;&gt; -                                               ifFalse: [ self error ] ].<br>
&gt; &gt;&gt; -                       currentToken = &#39;module:&#39;<br>
&gt; &gt;&gt; -                               ifTrue: [<br>
&gt; &gt;&gt; -                                       self scanPast: #module.<br>
&gt; &gt;&gt; -                                       currentTokenFirst == $&#39;<br>
&gt; &gt;&gt; -                                               ifTrue: [ self parseString<br>
&gt; &gt;&gt; ]<br>
&gt; &gt;&gt; -                                               ifFalse: [<br>
&gt; &gt;&gt; -                                                       currentTokenFirst<br>
&gt; &gt;&gt; == $#<br>
&gt; &gt;&gt; -                                                               ifTrue: [<br>
&gt; &gt;&gt; self parseSymbol ]<br>
&gt; &gt;&gt; -                                                               ifFalse: [<br>
&gt; &gt;&gt; self error ] ] ] ].<br>
&gt; &gt;&gt; -       self failUnless: currentTokenFirst == $&gt;.<br>
&gt; &gt;&gt;        self scanPast: #primitiveOrExternalCallEnd!<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;<br>
&gt; &gt;<br>
&gt;<br>
&gt;<br>
<br>
</div></div></blockquote></div><br></div>