<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>Am 06.01.2011 um 12:41 schrieb Bert Freudenberg:</div><blockquote type="cite"><div>On 05.01.2011, at 22:28, Bernhard Pieber wrote:<br>Hi Bert,<br><blockquote type="cite"><br></blockquote><blockquote type="cite">Thanks for your answer!<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Am 05.01.2011 um 16:36 schrieb Bert Freudenberg:<br></blockquote><blockquote type="cite"><blockquote type="cite">On 05.01.2011, at 12:03, Bernhard Pieber wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">It just occurred to me that the broken tests can be fixed if the following is put to the trunk as a postscript or preamble:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">PackageOrganizer default<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span class="Apple-tab-span" style="white-space:pre"> </span>unregisterPackageNamed: 'PackageInfo';<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span class="Apple-tab-span" style="white-space:pre"> </span>unregisterPackageNamed: 'ToolBuilder';<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span class="Apple-tab-span" style="white-space:pre"> </span>unregisterPackageNamed: 'Morphic-TrueType'<br></blockquote></blockquote></blockquote><blockquote type="cite">Would you be opposed to put this to the trunk? I cannot see any adverse effect on anyone's image.<br></blockquote><br>I wouldn't be opposed. AFAICT there are no preambles/postscripts in these instances so we would not loose anything. I just don't see the point either. E.g., at least in my trunk image there are 81 registered package infos but only 60 working copies. So why delete these 3?<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div>Because these three are the minimum needed to fix the failing PackageDependencyTest tests which fail because of non Monticello PackageInfos. See my other mail.</div><br><blockquote type="cite"><div><blockquote type="cite"><blockquote type="cite">Maybe PackageDependencyTest should be made less whiny? By default it should not complain about those packages. You only want to ensure that a release image is clean, not every working image.<br></blockquote></blockquote><blockquote type="cite">Good idea. One way to make it less whiny would be to only take into account PackageInfos associated with a Monticello MCWorkingCopy. I *think* this was the intention behind the PackageDependencyTest anyway.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Perhaps unit tests aren't the best way to ensure a clean release. They're supposed to exercise code. ReleaseBuilder does some sanity checks already, maybe it should also check for clean packages.<br></blockquote></blockquote></div></blockquote>What sanity checks are you referring to?</div><div><br><blockquote type="cite"><div><blockquote type="cite">I don't think so. I kind of like this test. I think it is useful for improving the package structure. And it should only affect trunk packages, not your code. Once the obsolete PackageInfos are cleaned it will be more useful. We can then use it to flag unwanted dependencies, e.g. PackageInfo-Base should not depend on Morphic.<br></blockquote><br>It certainly is useful. But why does it have to be a unit test?<br></div></blockquote></div>In that form every developer can deal with it. I find Andreas' explanation convincing:<div><a href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-March/145343.html">http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-March/145343.html</a></div><div><br></div><div>Anyway, it is no big deal. I am looking forward to the release. Thanks to all of you!</div><div><br></div><div>Cheers,</div><div>Bernhard</div></body></html>