<br><br><div class="gmail_quote">On Tue, Jul 12, 2011 at 11:16 AM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I already added isLarge, but it is only defined in Integer subclasses.<br>This is used by divide and conquer ascii to binary conversion.<br></blockquote><div><br></div><div>The default isLarge ^false needs to be in Number to use it here, right? Even then it may have to be guarded with isNumber if we're talking about #= & #~=.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><font color="#888888"><br>Nicolas</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">2011/7/12 Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">So add isLargeInteger to Number and LargePosiitveInteger and LargeNegativeInteger and use that instead. It may even be faster ;)<div>
<div></div><div><br><br><div class="gmail_quote">On Tue, Jul 12, 2011 at 8:05 AM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">I need to test it, but this looks like it will hurt me. I have<br>
subclassed LargePositiveInteger but I need it to compare equally - but<br>
with this hard class-check it will now fail....<br>
<div><div></div><div><br>
On Sun, Jul 10, 2011 at 9:36 AM, <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br>
> Levente Uzonyi uploaded a new version of Kernel to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Kernel-ul.604.mcz" target="_blank">http://source.squeak.org/trunk/Kernel-ul.604.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Kernel-ul.604<br>
> Author: ul<br>
> Time: 10 July 2011, 4:36:20.467 pm<br>
> UUID: f758876f-a507-404b-aa2f-2c1038504b48<br>
> Ancestors: Kernel-bf.603<br>
><br>
> Optimized Integer >> #= for integer-integer comparisons. Return false for integers from different classes without further checking.<br>
><br>
> =============== Diff against Kernel-bf.603 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: Integer>>= (in category 'comparing') -----<br>
> = aNumber<br>
> +<br>
> + aNumber isInteger ifTrue: [<br>
> + aNumber class == self class ifFalse: [ ^false ].<br>
> + ^(self digitCompare: aNumber) = 0 ].<br>
> + aNumber isNumber ifFalse: [ ^false ].<br>
> + ^aNumber adaptToInteger: self andCompare: #=!<br>
> - aNumber isNumber ifFalse: [^ false].<br>
> - aNumber isInteger ifTrue:<br>
> - [aNumber negative == self negative<br>
> - ifTrue: [^ (self digitCompare: aNumber) = 0]<br>
> - ifFalse: [^ false]].<br>
> - ^ aNumber adaptToInteger: self andCompare: #=!<br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br></div></div>-- <br>best,<div>Eliot</div><font color="#888888"><br>
</font><br><br>
<br></blockquote></div><br>
</div></div><br><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>best,<div>Eliot</div><br>