<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">
<br>
</div>Hi Mariano,<br>
<br>
I loaded Fuel into my working Squeak image, which is an older image kept up<br>
to date with trunk via the update stream (i.e. it is "bleeding edge" with<br>
various additional packages loaded).<br>
<br></blockquote><div><br>Excellent :)<br>Where can I get a "bleeding edge" Squeak image? <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I had to implement SystemVersion>>major and SystemVersion>>minor to complete<br>
the installation (these are Pharo idioms, so I just implemented them to<br>
answer 0 on Squeak).<br></blockquote><div><br><br>To complete the instalation?? Can you remember why (the sender) it is needing #mayor and #minor? <br>As far as I remember, it is only used by Fuel in FLBasicSerializationTest >> expectedFailures <br>
but that is not the installation, but running tests.<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
I did not encounter the timeout problem, but if you have a long running<br>
test, just add a pragma like <timeout: 30> to set the timeout to 30 seconds.<br>
This will increase the timeout when running on Squeak, and should not<br>
affect Pharo.<br></blockquote><div><br>Thanks, I didn't know. Is there a way to run the tests in the test runner so that it doesn't take into account such timeouts?<br>or can I change the global preference? I ask so that to avoid changing tests code (even if they would work for Pharo).<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Below are some notes that I took while running the tests. The most important<br>
issue would be the tests that fail in CompiledMethod comparison. I cannot<br>
say if this is a Fuel issue or just something about the way the tests are<br>
written, but I note significant differences in the implementation of<br>
CompiledMethod>>= between Squeak and Pharo, so it is definitely something<br>
worth checking.<br>
<br></blockquote><div><br>That's a good point. There must be something there for sure. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Notes on test issues in FuelTests:<br>
<br>
FLSequencedSerializationTest>>assertSequencedSerializationEqualityOf:<br>
is failing due to difference in CompiledMethod>>= between Pharo and<br>
Squeak. Not sure if this is a Fuel issue.<br>
<br>
FLBasicSerializationTest>>testGradientFillStyle fails because GradientFillStyle>>=<br>
is an identity test, whereas in Pharo it has been added from package<br>
'*PolyMorph-Widgets' (i.e. not part of base Pharo either).<br>
<br>
FLBasicSerializationTest>>testMethodDictionary fails due to compiled method #=<br>
(same issue as FLSequencedSerializationTest>>assertSequencedSerializationEqualityOf:)<br>
<br>
In FLBlockClosureSerializationTest, all tests fail with an assertion failure<br>
in MethodContext<br>
<br>
FLFullBasicSerializationTest>>testMethodDictionaries fails due to the<br>
compiled method equality check problem.<br>
<br>
FLMethodContextSerializationTest tests fail with assertion failure in<br>
MethodContext<br>
<br>
FLSortedCollectionSerializationTest tests fail with assertion failure<br>
in MethodContext<br>
<br>
FLCreateClassSerializationTest has errors due to DNU from<br>
ClassForTestToBeDeleted1 class>>basicLocalSelectors<br>
<br>
FLCompiledMethodSerializationTest>>testTwoCompiledMethodsReferencingSameClassVariable<br>
fails due to the compiled method equality check problem.<br>
<br>
FLCreateTraitSerializationTest>>testCreateBasic fails with DNU<br>
on Trait>>basicLocalSelectors<br>
<br>
<br></blockquote><div><br>Thanks for the detailed answer. From what I can see, even if those tests are wrong, "most cases" should work fine. <br></div></div><br>Cheers<br clear="all"><br>-- <br>Mariano<br><a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
<br>