<br><br><div class="gmail_quote">On Mon, Mar 19, 2012 at 3:17 PM, Bert Freudenberg <span dir="ltr"><<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Mea culpa! But thank you :)<br></blockquote><div><br></div><div>you're most welcome :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#888888"><br>
- Bert -<br>
</font><div><div></div><div class="h5"><br>
On 19.03.2012, at 21:51, <a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a> wrote:<br>
<br>
> Eliot Miranda uploaded a new version of Kernel to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Kernel-eem.675.mcz" target="_blank">http://source.squeak.org/trunk/Kernel-eem.675.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Kernel-eem.675<br>
> Author: eem<br>
> Time: 19 March 2012, 2:51:13.711 pm<br>
> UUID: 44dbc698-62dc-4f6b-afd0-c987fdadb1f7<br>
> Ancestors: Kernel-eem.674<br>
><br>
> Fix the improved decompileWithTempNames for doits<br>
> without temp names. 673 breaks e.g.<br>
> DecompilerTests new testRemoteTemp<br>
><br>
> =============== Diff against Kernel-eem.674 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: CompiledMethod>>decompileWithTemps (in category 'decompiling') -----<br>
> decompileWithTemps<br>
> + "Return the decompiled parse tree that represents self, but with the temp names obtained<br>
> + either by compiling the sourcecode, or directly if the method has temps in its trailer."<br>
> - "Return the decompiled parse tree that represents self, but with the temp names<br>
> - either by compiling the sourcecode, or direct if the method has temps in its trailer."<br>
><br>
> + | class selector tempNames source |<br>
> - | class selector tempNames |<br>
> class := self methodClass ifNil: [Object].<br>
> selector := self selector ifNil: [self defaultSelector].<br>
><br>
> + self holdsTempNames<br>
> + ifTrue: [tempNames := self tempNamesString]<br>
> + ifFalse:<br>
> + ["No source file or no source (e.g. doits) and no temp names<br>
> + -- decompile without temp names "<br>
> + ((self fileIndex > 0 and: [(SourceFiles at: self fileIndex) isNil])<br>
> + or: [(source := self getSourceFromFile) isNil]) ifTrue:<br>
> + [^self decompile].<br>
> + tempNames := (class newCompiler<br>
> + parse: source asString<br>
> - (self fileIndex > 0 and: [(SourceFiles at: self fileIndex) isNil]) ifTrue:<br>
> - "Emergency or no source file -- decompile without temp names "<br>
> - [^self decompile].<br>
> -<br>
> - tempNames := self holdsTempNames<br>
> - ifTrue: [self tempNamesString]<br>
> - ifFalse: [(class newCompiler<br>
> - parse: self getSourceFromFile asString<br>
> in: class<br>
> notifying: nil)<br>
> generate: CompiledMethodTrailer defaultMethodTrailer;<br>
> schematicTempNamesString].<br>
> +<br>
> ^(self decompilerClass new withTempNames: tempNames)<br>
> decompile: selector<br>
> in: class<br>
> method: self methodForDecompile!<br>
><br>
><br>
<br>
<br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>