<br><br><div class="gmail_quote">On Mon, Apr 9, 2012 at 7:16 PM, Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote">On Mon, Apr 9, 2012 at 4:04 AM, Bob Arning <span dir="ltr"><<a href="mailto:arning315@comcast.net" target="_blank">arning315@comcast.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<font face="Georgia">It works in 4.2 Mac for me. In </font>4.3, it
fails as you reported.<br></div></blockquote><div><br></div><div>So the change is then the discarding of shiftEncose: and its use in initializeShiftCmdKeyShortcuts. This change was made when the signature for enclose: et al was changed to take KeyboardEvents as arguments instead of the characterStream made in Morphic-nice.566. I agree with Nicholas' comment in Morphic-nice.566 that "#shiftEnclose: is hardcoding the keyboard layout, which is not compatible with foreign keyboards and modern VM, and prevents correct enclosing to work.". Looks like there isn't enough information in a KeyboardEvent, e.g. the shifted and unshifted characters, for enclose: to do the right thing. We need both the shifted and the unshifted character, and then enclose: can do the right thing. But the VM does not pass up this information yet. </div>
<div><br></div><div>I propose we modify the VMs asap to use the "reserved1" 7th field in a sqKeyboardEvent to contain the modified character as answered by the OS. For and against?<br></div></div></blockquote><div>
<br>Maybe I'm not totally aware of the problem, but why do you need the unshifted character? The shortcut should get activated on one of the enclosable characters ()[]{}<>, and that's all...<br><br>Guille<br>
</div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div> </div></div></blockquote><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<br>
Cheers,<br><font color="#888888">
Bob</font><div><div></div><div><br>
<br>
On 4/8/12 3:46 PM, Eliot Miranda wrote:
<blockquote type="cite">Hi All,
<div><br>
</div>
<div> in the current 4.3 trunk shift-enclose on Mac doesn't
work, it performs the unshifted enclose. e.g.
command-shift-single-quote (which is double quote) encloses with
a single quote. I think this is an image issue. It has been
fine in my Qwaq/Teleplace image for ages, but in testing I see
it is broken in 4.2 also. Anyone have any idea what's going on
here?<span class="HOEnZb"><font color="#888888"><br>
-- <br>
best,
<div>Eliot</div>
<br>
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
<fieldset></fieldset>
<br>
<pre></pre>
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
</font></span></div></div></div><span class="HOEnZb"><font color="#888888">
<br><br>
<br></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>
</font></span><br><br>
<br></blockquote></div><br>