<br><br><div class="gmail_quote">On Wed, May 9, 2012 at 11:17 AM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Eliot, I just realized that Command+Shift+C is already allocated to<br>
"show category (C)" -- which is useful and still works because the<br>
keyboard handler method was not actually updated (that I saw<br>
anyway..).<br>
<br>
Should we think of with a different hot-key (maybe Command+Shift+R ?)<br>
to handle it?<br></blockquote><div><br></div><div>Sounds good.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Mon, Apr 16, 2012 at 3:52 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Eliot Miranda uploaded a new version of Tools to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Tools-eem.402.mcz" target="_blank">http://source.squeak.org/trunk/Tools-eem.402.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Tools-eem.402<br>
> Author: eem<br>
> Time: 16 April 2012, 1:52:23.177 pm<br>
> UUID: 60d5c35a-b436-4fb2-af42-9af40bfb4001<br>
> Ancestors: Tools-eem.401<br>
><br>
> Provide a short-cut (cmd-shift-C) for copyReference.<br>
><br>
> Nuke null method in TimeProfileBrowser's menu processing.<br>
><br>
> Make the same bounds check in the indirect temp ref side<br>
> of privateDereference:in:.<br>
><br>
> =============== Diff against Tools-eem.401 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: Browser>>messageListMenu:shifted: (in category 'message functions') -----<br>
> messageListMenu: aMenu shifted: shifted<br>
> "Answer the message-list menu"<br>
> self<br>
> menuHook: aMenu<br>
> named: #messageListMenu<br>
> shifted: shifted.<br>
> Preferences useOnlyServicesInMenu ifTrue:[^aMenu].<br>
> shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].<br>
> aMenu addList: #(<br>
> ('what to show...' offerWhatToShowMenu)<br>
> ('toggle break on entry' toggleBreakOnEntry)<br>
> -<br>
> ('browse full (b)' browseMethodFull)<br>
> ('browse hierarchy (h)' classHierarchy)<br>
> ('browse method (O)' openSingleMessageBrowser)<br>
> ('browse protocol (p)' browseFullProtocol)<br>
> -<br>
> + ('fileOut' fileOutMessage)<br>
> + ('printOut' printOutMessage)<br>
> + ('copy selector (c)' copySelector)<br>
> + ('copy reference (C)' copyReference)<br>
> - ('fileOut' fileOutMessage)<br>
> - ('printOut' printOutMessage)<br>
> - ('copy selector (c)' copySelector)<br>
> - ('copy reference' copyReference)<br>
> -<br>
> ('senders of... (n)' browseSendersOfMessages)<br>
> ('implementors of... (m)' browseMessages)<br>
> ('inheritance (i)' methodHierarchy)<br>
> ('versions (v)' browseVersions)<br>
> -<br>
> ('references... (r)' browseVariableReferences)<br>
> ('assignments... (a)' browseVariableAssignments)<br>
> ('class refs (N)' browseClassRefs)<br>
> -<br>
> ('remove method (x)' removeMessage)<br>
> ('explore method' exploreMethod)<br>
> ('inspect method' inspectMethod)<br>
> -<br>
> ('more...' shiftedYellowButtonActivity)).<br>
> ^ aMenu!<br>
><br>
> Item was changed:<br>
> ----- Method: DebuggerMethodMapForClosureCompiledMethods>>privateDereference:in: (in category 'private') -----<br>
> privateDereference: tempReference in: aContext<br>
> "Fetch the temporary with reference tempReference in aContext.<br>
> tempReference can be<br>
> integer - direct temp reference<br>
> #( indirectionVectorIndex tempIndex ) - remote temp in indirectionVector at index<br>
> #( outer. temp reference ) - a temp reference in an outer context."<br>
> ^tempReference isInteger<br>
> ifTrue:<br>
> [tempReference <= aContext stackPtr ifTrue:<br>
> [aContext tempAt: tempReference]]<br>
> ifFalse:<br>
> [tempReference first == #outer<br>
> ifTrue:<br>
> [self privateDereference: tempReference last<br>
> in: aContext outerContext]<br>
> ifFalse: "If stopped before indirection vectors are created they will be nil. Simply answer nil"<br>
> + [tempReference first <= aContext stackPtr ifTrue:<br>
> + [(aContext tempAt: tempReference first) ifNotNil:<br>
> + [:indirectionVector|<br>
> + indirectionVector at: tempReference second]]]]!<br>
> - [(aContext tempAt: tempReference first) ifNotNil:<br>
> - [:indirectionVector|<br>
> - indirectionVector at: tempReference second]]]!<br>
><br>
> Item was changed:<br>
> ----- Method: MessageSet>>messageListMenu:shifted: (in category 'message functions') -----<br>
> messageListMenu: aMenu shifted: shifted<br>
> "Answer the message-list menu"<br>
> self<br>
> menuHook: aMenu<br>
> named: #messageListMenu<br>
> shifted: shifted.<br>
> Preferences useOnlyServicesInMenu ifTrue:[^aMenu].<br>
> shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].<br>
> aMenu addList: #(<br>
> ('what to show...' offerWhatToShowMenu)<br>
> ('toggle break on entry' toggleBreakOnEntry)<br>
> -<br>
> ('browse full (b)' browseMethodFull)<br>
> ('browse hierarchy (h)' classHierarchy)<br>
> ('browse method (O)' openSingleMessageBrowser)<br>
> ('browse protocol (p)' browseFullProtocol)<br>
> -<br>
> ('fileOut' fileOutMessage)<br>
> ('printOut' printOutMessage)<br>
> + ('copy selector (c)' copySelector)<br>
> + ('copy reference (C)' copyReference)<br>
> - ('copy selector (c)' copySelector)<br>
> - ('copy reference' copyReference)<br>
> -<br>
> ('senders of... (n)' browseSendersOfMessages)<br>
> ('implementors of... (m)' browseMessages)<br>
> ('inheritance (i)' methodHierarchy)<br>
> ('versions (v)' browseVersions)<br>
> -<br>
> ('references... (r)' browseVariableReferences)<br>
> ('assignments... (a)' browseVariableAssignments)<br>
> ('class refs (N)' browseClassRefs)<br>
> -<br>
> ('remove method (x)' removeMessage)<br>
> ('explore method' exploreMethod)<br>
> ('inspect method' inspectMethod)<br>
> -<br>
> ('more...' shiftedYellowButtonActivity)).<br>
> ^ aMenu!<br>
><br>
> Item was changed:<br>
> ----- Method: RecentMessageSet>>messageListMenu:shifted: (in category 'message functions') -----<br>
> messageListMenu: aMenu shifted: shifted<br>
> "Answer the message-list menu"<br>
><br>
> shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].<br>
> aMenu addList:#(<br>
> ('what to show...' offerWhatToShowMenu)<br>
> -<br>
> ('browse full (b)' browseMethodFull)<br>
> ('browse hierarchy (h)' classHierarchy)<br>
> ('browse method (O)' openSingleMessageBrowser)<br>
> ('browse protocol (p)' browseFullProtocol)<br>
> -<br>
> + ('fileOut (o)' fileOutMessage)<br>
> - ('fileOut (o)' fileOutMessage)<br>
> ('printOut' printOutMessage)<br>
> ('copy selector (c)' copySelector)<br>
> + ('copy reference (C)' copyReference)<br>
> - ('copy reference' copyReference)<br>
> -<br>
> ('senders of... (n)' browseSendersOfMessages)<br>
> ('implementors of... (m)' browseMessages)<br>
> + ('inheritance (i)' methodHierarchy)<br>
> - ('inheritance (i)' methodHierarchy)<br>
> ('versions (v)' browseVersions)<br>
> -<br>
> ('references... (r)' browseVariableReferences)<br>
> ('assignments... (a)' browseVariableAssignments)<br>
> ('class refs (N)' browseClassRefs)<br>
> -<br>
> ('remove method (x)' removeMessage)<br>
> ('remove from RecentSubmissions' removeFromRecentSubmissions)<br>
> -<br>
> ('more...' shiftedYellowButtonActivity)).<br>
> ^ aMenu!<br>
><br>
> Item was removed:<br>
> - ----- Method: TimeProfileBrowser>>messageListMenu:shifted: (in category 'private') -----<br>
> - messageListMenu: aMenu shifted: shifted<br>
> - "Add a menu to the inherited one."<br>
> -<br>
> - | menu |<br>
> - menu := super messageListMenu: aMenu shifted: shifted.<br>
> - " menu addItem: (0)."<br>
> - ^menu!<br>
><br>
><br>
<br><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>