So given that the Interpreter VM now supports the mirror primitives, does anyone object if I add the debugger changes to trunk that use the mirror primitives and hence make accurate debugging of proxies possible? The downside of doing this is that the debugger will be broken on older VMs.<div>
<br></div><div>As an example of the changes here are the old and new methods form pushing an inst var in the debugger/execution simulator. The first one sends a message to the receiver, and hence if it is a proxy will invoke the proxy's doesNotUnderstand: handling rather than answering the relevant inst var. The second one directly accesses the relevant inst var, accurately simulating what the VM does for the bytecode. The changes replace direct sends with use of mirror primitives throughout execution simulation in all the places where the VM would do a direct access rather than send a message.<br>
<br></div><div>ContextPart methods for instruction decoding</div><div><div>pushReceiverVariable: offset </div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Simulate the action of bytecode that pushes the contents of the receiver's </div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>instance variable whose index is the argument, index, on the top of the stack."</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>self push: (self receiver instVarAt: offset + 1)</div>
<div><br></div><div>ContextPart methods for instruction decoding</div><div><div>pushReceiverVariable: offset </div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Simulate the action of bytecode that pushes the contents of the receiver's </div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>instance variable whose index is the argument, index, on the top of the stack."</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>self push: (self object: self receiver instVarAt: offset + 1)</div>
</div><div><br></div><div>and here's the mirror method. c.f. Object>instVarAt:. They share the same primitive number because internally the VM implements varargs primitives.</div><div>ContextPart methods for mirror primitives</div>
<div><div>object: anObject instVarAt: anIndex</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Primitive. Answer a fixed variable in an object. The numbering of the </div><div><span class="Apple-tab-span" style="white-space:pre"> </span> variables corresponds to the named instance variables. Fail if the index </div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span> is not an Integer or is not the index of a fixed variable. Essential for the</div><div><span class="Apple-tab-span" style="white-space:pre"> </span> debugger. See Object documentation whatIsAPrimitive."</div>
<div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span><primitive: 73></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Access beyond fixed variables."</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>^self object: anObject basicAt: anIndex - (self objectClass: anObject) instSize</div></div><div><br></div><div class="gmail_quote">On Tue, May 22, 2012 at 8:17 PM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, May 22, 2012 at 03:24:34PM -0700, Eliot Miranda wrote:<br>
> On Tue, May 22, 2012 at 12:07 AM, Colin Putney <<a href="mailto:colin@wiresong.com">colin@wiresong.com</a>> wrote:<br>
><br>
> > Hi all,<br>
> ><br>
> > I've just uploaded a package to the Inbox for review by the community:<br>
> ><br>
> > <a href="http://source.squeak.org/inbox/Mirrors-cwp.2.mcz" target="_blank">http://source.squeak.org/inbox/Mirrors-cwp.2.mcz</a><br>
> ><br>
> > It's a simple first step at creating a mirror API for Squeak. I've only<br>
> > implemented ObjectMirror and ObjectVmMirror, which provide high- and<br>
> > low-level reflection on an object. This implementation has a twist,<br>
> > however: it sends no messages to the object it's reflecting. That allows us<br>
> > to reflect on network proxies, ORM stubs, mock objects and the like without<br>
> > triggering any state changes.<br>
> ><br>
> > As a proof of the concept, I've implemented a rudimentary non-invasive<br>
> > MirrorInspector. The main thing that's missing is non-invasive printing,<br>
> > which would take a bit of work to implement, but isn't necessary for a<br>
> > demo. To see it in action do try the following in a workspace.<br>
> ><br>
> > WARNING: Read the comments carefully, and don't do this in an image you<br>
> > care about!<br>
> ><br>
> > "This creates a very dangerous object"<br>
> > Object subclass: #Nuke<br>
> > instanceVariableNames: 'one two three'<br>
> > classVariableNames: ''<br>
> > poolDictionaries: ''<br>
> > category: 'Test'.<br>
> > class := Smalltalk at: #Nuke.<br>
> > class superclass: nil.<br>
> > inst := class basicNew.<br>
> ><br>
> > "This is harmless"<br>
> > MirrorInspector inspect: inst.<br>
> ><br>
> > "This will crash your image"<br>
> > inst yourself.<br>
> ><br>
> > The implementation uses primitive 188 to directly execute CompiledMethods<br>
> > with the reflected object as the receiver, thus giving us access to the<br>
> > object's state without sending it a message.<br>
> ><br>
><br>
> In part you can use the light-weigth mirror methods in ContextPart, these<br>
> take the object operated on as an argument. Non-invasive printing could be<br>
> done via execution simulation. I've already modified the Squeak debugger<br>
> in Qwaq/Teleplace images to use these light-weight mirror primitives so<br>
> that messages are not sent to receivers when simulating execution in the<br>
> debugger (i.e. when doing send instead of step). If the mirror primitives<br>
> now work on the interpreter I can fold this into trunk. David, do the<br>
> mirror primitive tests pass on the interpreter?<br>
<br>
</div></div>All mirror primitive tests pass on the interpreter VM if built with the<br>
latest VMMaker and SVN sources. However, the mirror primitive support is<br>
not yet present in any officially released standard VM.<br>
<br>
The updates for mirror primitive support were added in VMMaker-dtl.262 and<br>
VMMaker-dtl.261. Note the update comment in VMMaker-dtl.262, as the<br>
implementation differs from Cog and a code review would be welcome:<br>
<br>
Name: VMMaker-dtl.262<br>
Author: dtl<br>
Time: 5 January 2012, 12:41:29.745 am<br>
<br>
VMMaker 4.7.19<br>
<br>
Reference Mantis 7429: Add Mirror Primitives to the VM<br>
<br>
Update primitivePerformInSuperclass to support ContextPart>>object:perform:withArguments:inClass:<br>
<br>
Implementation differs from that of oscog in that the original primitivePerformAt:<br>
is retained unmodified, and the necessary stack adjustments are done in<br>
primitivePerformInSuperclass for the special case of argumentCount 4<br>
(mirror primitive call) rather than 3. The oscog approach may be prefered<br>
(not least for its clearer method naming), but making the change in<br>
primitivePerformInSuperclass is low risk and more easily implemented by<br>
a Sunday Squeaker.<br>
<br>
All MirrorPrimitiveTests pass.<br>
<br>
Dave<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>
</div>