<br><br><div class="gmail_quote">On Tue, Nov 6, 2012 at 5:44 AM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This update results in a new test failure in ClosureCompilerTest>>testDecompiledDoitMethodTempNames.<br>
This is probably just a test issue that can be fixed with an update to<br>
ClosureCompilerTest>>closureCases, but I am not an expert here.<br>
<br>
Eliot, Nicolas - could one of you please check this and fix the test if<br>
that is what is required?<br></blockquote><div><br></div><div>done. checking in soon.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also, a new test to document the problem being fixed by this update would<br>
be a good thing.<br></blockquote><div><br></div><div>will do.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
Dave<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Nov 06, 2012 at 01:03:30PM +0100, Nicolas Cellier wrote:<br>
> Some kind of Heisenberg principle, you cannot observe a node without<br>
> some sort of interaction ;).<br>
> We should create a price for the best anti-pattern of the month.<br>
> It's invaluable for teaching.<br>
><br>
> Nicolas<br>
><br>
> 2012/11/6 <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>>:<br>
> > Eliot Miranda uploaded a new version of Compiler to project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/Compiler-eem.239.mcz" target="_blank">http://source.squeak.org/trunk/Compiler-eem.239.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: Compiler-eem.239<br>
> > Author: eem<br>
> > Time: 5 November 2012, 3:09:13.298 pm<br>
> > UUID: 074c58f2-bc92-4c3f-adff-56c47d3884ef<br>
> > Ancestors: Compiler-eem.238<br>
> ><br>
> > Eliminate horrible side-effect in printing whileTrue/whileFalse<br>
> > nodes that undid the tranformation to whileTrue:/whileFalse:.<br>
> ><br>
> > =============== Diff against Compiler-eem.238 ===============<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: MessageNode>>printWhileOn:indent: (in category 'printing') -----<br>
> > printWhileOn: aStream indent: level<br>
> > -<br>
> > self printReceiver: receiver on: aStream indent: level.<br>
> > + self<br>
> > + printKeywords: originalSelector<br>
> > + arguments: originalArguments<br>
> > - (arguments isEmpty not<br>
> > - and: [arguments first isJust: NodeNil]) ifTrue:<br>
> > - [selector := SelectorNode new<br>
> > - key:<br>
> > - (selector key == #whileTrue:<br>
> > - ifTrue: [#whileTrue]<br>
> > - ifFalse: [#whileFalse])<br>
> > - code: #macro.<br>
> > - arguments := Array new].<br>
> > - self printKeywords: selector key arguments: arguments<br>
> > on: aStream indent: level!<br>
> ><br>
> ><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>