<div dir="ltr">Hi Edgar,<div><br></div><div><span class=""> the package comment is good. But the source isn't. If I were to come back in a year or two I would want to know why the send line had been commented out and why the </span><span class="" style="font-family:arial,sans-serif;font-size:14px;color:rgb(0,0,0)">appendVocabularies:</span><span class=""> method had been kept. But reading the source I would have no clue.</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 18, 2012 at 3:22 AM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A new version of GetText was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/GetText-edc.26.mcz" target="_blank">http://source.squeak.org/inbox/GetText-edc.26.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: GetText-edc.26<br>
Author: edc<br>
Time: 18 December 2012, 8:23:27.014 am<br>
UUID: a6073c36-9cee-4419-a727-389696afd8ad<br>
Ancestors: GetText-nice.25<br>
<br>
This modification is for when you perform Smalltalk unloadAllKnownPackages on Squeak4.4-RC2.tgz the image don't crash<br>
<br>
=============== Diff against GetText-nice.25 ===============<br>
<br>
Item was changed:<br>
----- Method: GetTextExporter>>appendTranslations: (in category 'exporting') -----<br>
appendTranslations: domains<br>
self appendStringReceivers: #translated into: domains.<br>
self appendStringReceivers: #translatedNoop into: domains.<br>
+ "self appendVocabularies: domains."<br>
- self appendVocabularies: domains.<br>
!<br>
<br>
Item was removed:<br>
- ----- Method: GetTextExporter>>appendVocabularies: (in category 'private') -----<br>
- appendVocabularies: domains<br>
- | literalsForDomain references domainName methodReference |<br>
-<br>
- EToyVocabulary allPhrasesWithContextToTranslate do: [ :r |<br>
- methodReference := (MethodReference new setStandardClass: (r second) methodSymbol: (r third)).<br>
- "domainName := self getTextDomainForPackage: (PackageOrganizer default packageOfMethod: methodReference)".<br>
- domainName := 'Etoys-Tiles'.<br>
- literalsForDomain := domains at: domainName ifAbsentPut: [Dictionary new].<br>
- r fourth do: [ :literal |<br>
- references := literalsForDomain at: literal ifAbsentPut: [OrderedCollection new].<br>
- references add: methodReference.<br>
- ].<br>
- ].<br>
- !<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div><br>
</div>