<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Georgia">In looking at where one test fails I see that<br>
<br>
MCSnapshotResource current snapshot definitions<br>
<br>
is empty in the 4.4 image while it has a bunch of entries in the
4.3 image.<br>
<br>
Cheers,<br>
Bob<br>
<br>
</font>
<div class="moz-cite-prefix">On 12/19/12 5:44 PM, Frank Shearar
wrote:<br>
</div>
<blockquote
cite="mid:CAJbhyRHEB3QScuxtfeT9Hv_KA5EDY7Jod-1yAXfC9y78u_F_0A@mail.gmail.com"
type="cite">
<pre wrap="">On 19 December 2012 22:15, Chris Muller <a class="moz-txt-link-rfc2396E" href="mailto:ma.chris.m@gmail.com"><ma.chris.m@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Why do you say that's breaking the tests? If you "Do It" on one of
the failed MC tests it opens the debugger showing the failed assertion
even though initials have already been set.
</pre>
</blockquote>
<pre wrap="">
If the author initials aren't set, you get a FITBM asking for it. The
proper cleanup and restoration of MC's test state will thus not
happen. In particular, MCMockClassA does not get its #one method back,
which later tests expect.
</pre>
<blockquote type="cite">
<pre wrap="">These tests weren't failing in 4.3 anyone know what happened?
</pre>
</blockquote>
<pre wrap="">
People usually don't run tests without author initials? Certainly
these tests have ALWAYS passed on CI, but CI sets the author initials.
I have yet to see evidence to contradict my hypothesis.
</pre>
</blockquote>
<pre wrap="">
Eh, well I just opened the 4.3 release image and ran tests. It asked
for my initials at the beginning and then ran all tests. Those MC
tests didn't fail. I don't think we can release without understanding
what's going on with them in 4.4.
</pre>
</blockquote>
<pre wrap="">
Yes, but did you _fill in_ the initials?
At any rate, theories aside, it _is_ the case that the
MCMethodDefinitionTest >> #tearDown doesn't restore state correctly.
Note that this is #testLoadAndUnload test is the test that pops up the
prompt. Subsequent tests fail because, for at least some of them,
MCMockClassA >> #one no longer exists. (MCMethodDefinitionTest >>
#testLoadAndUnload removes it.)
</pre>
<blockquote type="cite">
<pre wrap="">Would someone volunteer? I'm currently looking at Dave's SqueakMap
patch is needed now but not before and making sure we can, in fact,
deploy packages for 4.4 that will show up in SqueakMaps 4.4 list.
</pre>
</blockquote>
<pre wrap="">
Yes, please. I would like some countervailing evidence and/or
alternate hypotheses.
Nevertheless, these tests definitely run on CI, and definitely pass.
Have always passed, in fact. It was only glenpaling's recent findings
that brought these tests to my/our attention.
frank
</pre>
</blockquote>
<br>
</body>
</html>