<div dir="ltr"><div></div><div>How can this happen ?<br>Here is a theory (unverified, and with no code under my eyes):<br></div><div>- we change Environment, this triggers a recompile of some methods,<br>- then we fix Compiler/Decompiler but we do not trigger a recompile<br>
</div><div>-> the image is in bad state<br><br></div><div>It ill be solved<br></div><div>- either by a new Environment change that would recompile the same methods<br></div><div>- or a Compiler recompileAll<br><br></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/4/17 Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yes, but that didn't happen in the last 24 hours did it? Because<br>
that's the time difference between the two builds.<br>
<br>
Or do you mean that your decompilation fixes plus my Compiler<br>
recompileAll resulted in not creating "bad" stuff in the new<br>
updated-from-4.4 image?<br>
<br>
frank<br>
<br>
On 17 April 2013 13:57, Nicolas Cellier<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
> Yes, as I already said, I corrected the decompiler to be in line with the<br>
> modification of Compiler by Eliot, and the recompilation of the system "fait<br>
> monter la mayonnaise" (sorry, no time to dig for an english translation).<br>
><br>
><br>
> 2013/4/17 Frank Shearar <<a href="mailto:frank.shearar@gmail.com">frank.shearar@gmail.com</a>><br>
>><br>
>> I don't usually complain about tests passing, but in this case tests<br>
>> have passed that used to fail, but not because of code changes.<br>
>><br>
>> <a href="http://build.squeak.org/job/SqueakTrunk/272/testReport/" target="_blank">http://build.squeak.org/job/SqueakTrunk/272/testReport/</a> shows failures<br>
>> in decompiling and method highlighting that don't exist in<br>
>> <a href="http://build.squeak.org/job/SqueakTrunk/273/testReport/" target="_blank">http://build.squeak.org/job/SqueakTrunk/273/testReport/</a><br>
>><br>
>> The difference? I rebuilt the image under test: 273's image is<br>
>> 4.4-12327 updated to trunk, run through the release process [1] and<br>
>> then shrunk [2].<br>
>><br>
>> I _imagine_ the forced recompilation of everything is what's made the<br>
>> tests pass?<br>
>><br>
>> frank<br>
>><br>
>> [1]<br>
>> Form openAsBackground: (FileDirectory default / '..' /<br>
>> 'resources/wallpaper.png') pathName.<br>
>> Workspace allInstances do: [:w | w topView delete].<br>
>> ReleaseBuilderFor4dot5 prepareNewBuild. "this calls Compiler recompileAll"<br>
>> Smalltalk snapshot: true andQuit: true.<br>
>><br>
>><br>
>> [2]<br>
>> #('39Deprecated' '311Deprecated' '45Deprecated' 'Nebraska' 'Universes'<br>
>> 'XML-Parser') do: [ :pkgName |<br>
>> (MCPackage named: pkgName) unload.<br>
>> MCMcmUpdater disableUpdatesOfPackage: pkgName].<br>
>><br>
>> Smalltalk cleanUp.<br>
>><br>
><br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>