<br><br><div class="gmail_quote">On Sun, Apr 28, 2013 at 10:31 AM, Colin Putney <span dir="ltr"><<a href="mailto:colin@wiresong.com" target="_blank">colin@wiresong.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Sun, Apr 28, 2013 at 10:00 AM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">First, the problem can be observed simply by browsing references to<br>
the class Error, first from workspace text then from a class list.<br>
The root cause is that these use different ways to find the list of<br>
referencing methods. One uses:<br>
</blockquote><div> </div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><div class="im">
So, what is the proper fix here? 1) make bindingOf: and<br>
associationAt: point to the same object? 2) change<br>
CompiledMethod>>#indexOfLiteral: to do an equality rather than<br>
identity check? 3) change the IDE code to use #bindingOf: instead of<br>
#associationAt:?<br></div></blockquote><div><br></div><div>The proper fix is #3 - since compiling a method uses #bindingOf: searching for bindings should do the same.</div></div></div></div></blockquote><div><br></div><div>
I don't understand how #3 fixes things. If one has an alias to e.g. Error then all calls on Error should include references to the alias right? So doesn't there need to be some clever code for literalEqual: so that ALiases dereference to get the actual binding?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>I'll submit a fix shortly.</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div>Colin</div></font></span></div></div></div>
<br><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>