<html><head></head><body bgcolor="#FFFFFF"><div>Normally I would, but this is more complicated than a simple moving of a method. I don't know the how this method's used so I've assumed that proj is a Project-like thing, and there are no tests for this code (that I can see).</div><div><br></div><div>So I thought I'd ask before telling... this time :)</div><div><br>frank</div><div><br>On 03 Jun 2013, at 19:27, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><div dir="ltr">tell don't ask ;)<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/6/3 Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I just found this method. It contains this snippet:<br>
<br>
Smalltalk isMorphic ifTrue: [<br>
proj createViewIfAppropriate.<br>
] ifFalse: [<br>
ChangeSorter allChangeSets add: proj changeSet.<br>
ProjectView openAndEnter: proj.<br>
"Note: in MVC we get no further than the above"<br>
].<br>
<br>
Wouldn't that be better written by implementing<br>
<br>
MVCProject >> #createViewIfAppropriate<br>
ChangeSorter allChangeSets add: proj changeSet.<br>
ProjectView openAndEnter: proj.<br>
<br>
and ripping out the #isMorphic call?<br>
<span class="HOEnZb"><font color="#888888"><br>
frank<br>
<br>
</font></span></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span></span><br></div></blockquote></body></html>