<br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 2:39 PM, Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi All,<div><br></div><div> in SystemWindow>>addMorph:fullFrame: towards the bottom are the lines:<br><div><br></div><div><div><span style="white-space:pre-wrap"> </span>aMorph adoptPaneColor: self paneColor.</div>
<div><span style="white-space:pre-wrap"> </span>aMorph borderWidth: 1; borderColor: Color lightGray; color: Color white.</div></div><div><br></div><div>I'm adding a UpdatingThreePhaseButtonMorph checkBox to my window so, via ImageMorph>>colors: </div>
<div><br></div><div><div>ImageMorph>>color: aColor</div><div> super color: aColor.</div><div> (image depth = 1 and: [aColor isColor]) ifTrue: [</div><div> image colors: {Color transparent. aColor}.</div>
<div> self changed]</div></div><div><br></div><div>this has the effect of completely smashing the checkBox's normal image, and setting to white ScriptingSystem formAtKey: #CheckBoxOn, which is what the checkBox uses as its default image.</div>
<div><br></div><div>What business does SystemWindow have of smashing the colour of any morph added to it? Surely this is bogus, no?</div></div></blockquote><div><br></div><div>I see the regression. Back in 3.9 the method read</div>
<div><br></div><div><div><span class="Apple-tab-span" style="white-space:pre"> </span>(aMorph isKindOf: ImageMorph) ifFalse:[</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>aMorph adoptPaneColor: self paneColor.</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>aMorph borderWidth: 2; borderColor: #inset; color: Color transparent]</div></div><div><br></div><div>Unless anyone objects I'll put back this guard. it seems obviously correct (or rather, obviously less broken; the method also includes this priceless gem:</div>
<div><div><span class="Apple-tab-span" style="white-space:pre"> </span>(aMorph class name = #BrowserCommentTextMorph) ifTrue:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>[aLayoutFrame rightOffset: windowBorderWidth negated.</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>aLayoutFrame leftOffset: windowBorderWidth.</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>aLayoutFrame bottomOffset: windowBorderWidth negated.</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>aLayoutFrame topOffset: (windowBorderWidth negated) + 4].</div></div><div>).</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><span class="HOEnZb"><font color="#888888">-- <br>best,<div>Eliot</div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>