<div dir="ltr"><div><div>Hi Tim,<br>I did the change and the rationale is that the most logical Collection recipient for Character is String, what else?<br></div>OrderedCollection is totally arbitrary with this respect. <br>
</div><div>OK, you cannot add: to a String. But can you add: to (1 to: 10)? No you can't.<br></div><div>So, put together, the Rationale is simply a principle of least astonishment.<br></div><div><br></div><div>I just used this selector for own little experiments, then I used my commiter privilege (abused ?) to push the change to my benefit.<br>
</div><div>I only act like this when I think that my own benefit matches general benefit.<br></div><div>I have plenty of more questionnable changes that I don't push.<br></div><div>I'm sorry that general benefit does not mean everyone's benefit, but in this case I would tend to favour Levente solution, fix Scratch and keep the String recipient.<br>
<br></div><div>Cheers<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/7/18 tim Rowledge <span dir="ltr"><<a href="mailto:tim@rowledge.org" target="_blank">tim@rowledge.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On 17-07-2013, at 7:18 PM, Levente Uzonyi <<a href="mailto:leves@elte.hu">leves@elte.hu</a>> wrote:<br>
<br>
> On Wed, 17 Jul 2013, tim Rowledge wrote:<br>
><br>
>> Not long ago Character>to: was changed to return a String instead of an Array. That broke ObjectsTool>alphabeticTabs<br>
>><br>
>> Either we need to fix alphabeticTabs to re-convert the String to a collection, or rescind the change to Character>to:. It would help if the rationale for that change were known.<br>
><br>
> The fix is easy, just replace the line causing the bug with this:<br>
><br>
> tabLabels := ($a to: $z) collect: [:ch | ch asString] as: OrderedCollection.<br>
><br>
> I can't commit now, so please do it.<br>
<br>
</div>I had already sent a fix like that to Frank - since he's tearing up the system right now and I'm a bit occupied with Scratch modernisation - but I'm not convinced it is better than making $a to: $z go back to returning an Array. I *know* a String is kinda-sorta an array of characters - but I want to be assured that the change didn't bugger up any other methods as a side-effect. Why was it done? What efforts to ensure it didn't screw things were made?<br>
<div class="im"><br>
<br>
tim<br>
--<br>
tim Rowledge; <a href="mailto:tim@rowledge.org">tim@rowledge.org</a>; <a href="http://www.rowledge.org/tim" target="_blank">http://www.rowledge.org/tim</a><br>
</div>Strange OpCodes: YOGA: Exit Finite-State Mode<br>
<br>
<br>
<br>
</blockquote></div><br></div>