<div dir="ltr">Good work<div><br></div><div>Karl</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 6, 2013 at 12:24 AM, Bert Freudenberg <span dir="ltr"><<a href="mailto:bert@freudenbergs.de" target="_blank">bert@freudenbergs.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">... and that has appeared to work fine (except for Character DNU #null).<br>
<br>
So Collections-nice.527 is back, and the newly generated mcd works (I deleted the older mcds).<br>
<br>
Great job, Nicolas! We're back in business.<br>
<br>
- Bert -<br>
<div class="HOEnZb"><div class="h5"><br>
On 2013-08-06, at 00:02, Bert Freudenberg <<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>> wrote:<br>
<br>
> I applied Nicolas' changes to the squeaksource server image and will temporarily un-delete the mcz for testing.<br>
><br>
> - Bert - (back from vacation now)<br>
><br>
><br>
> On 2013-08-05, at 19:48, Frank Shearar <<a href="mailto:frank.shearar@gmail.com">frank.shearar@gmail.com</a>> wrote:<br>
><br>
>> I've deleted this commit from the update stream, just so that we<br>
>> unbreak the update stream.<br>
>><br>
>> Then we can test the change, and reapply it at a later point.<br>
>><br>
>> frank<br>
>><br>
>> On 2 August 2013 22:26, Nicolas Cellier<br>
>> <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
>>> Bert, I prepared a patch for a 3.10.2 image in two folds:<br>
>>> - 1) decode UTF8 from mcz sources<br>
>>> - 2) encode mcd and mcz sources in UTF8<br>
>>> I've rapidly tested, and the image seems OK after applying 1) or both.<br>
>>> If only first one is applied, then old images can continue to read new Mcd<br>
>>> from <a href="http://source.squeak.org" target="_blank">source.squeak.org</a><br>
>>> I don't know if this is a real requirement<br>
>>> If not, then you can load 2) too. In doubt, a bit of conservatism don't<br>
>>> hurt.<br>
>>><br>
>>> As for loading that in a non official 3.11, then you'll have to test a<br>
>>> bit...<br>
>>><br>
>>> Cheers<br>
>>><br>
>>> Nicolas<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> 2013/8/1 Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>><br>
>>>><br>
>>>> But Bert, where to find a Squeak 3.11alpha image #8824 ?<br>
>>>> The 3.11 stuff on <a href="http://ftp.squeak.org/" target="_blank">http://ftp.squeak.org/</a> is declared obsolete, and I did<br>
>>>> find anything but Level Playing Field there...<br>
>>>> The updates (stream) stop at 7159 (3.10) with Monticello-edc.312<br>
>>>> Then squeak4.1 starts at #9957 with Monticello-bp-387...<br>
>>>><br>
>>>><br>
>>>> 2013/7/31 Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>><br>
>>>>><br>
>>>>> Yes, it's a small change<br>
>>>>><br>
>>>>><br>
>>>>> 2013/7/30 Bert Freudenberg <<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>><br>
>>>>>><br>
>>>>>> FWIW, the server image is a Squeak 3.11alpha image #8824 with<br>
>>>>>> Monticello-bf.356. I'm afraid simply loading a current MC version is not<br>
>>>>>> going to work, but maybe the utf8 changes could be backported?<br>
>>>>>><br>
>>>>>> - Bert -<br>
>>>>>><br>
>>>>>> On 30.07.2013, at 22:26, Nicolas Cellier<br>
>>>>>> <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
>>>>>><br>
>>>>>> To me, the server should try and read in utf8, then fallback to old<br>
>>>>>> encoding like current trunk does.<br>
>>>>>> Then, whether it should continue to write with old encoding or utf8 is a<br>
>>>>>> question of how we want to support serving older images.<br>
>>>>>> Would it be possible to provide a hackish transition: create mcd with<br>
>>>>>> same encoding as mcz?<br>
>>>>>><br>
>>>>>><br>
>>>>>> 2013/7/30 Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>><br>
>>>>>>><br>
>>>>>>> A possible scenario:<br>
>>>>>>> For some reason (?) the snapshot.bin fails. In that case, the server<br>
>>>>>>> used the sources in .st format.<br>
>>>>>>> But newly produced sources are in utf8 and the server is probably not<br>
>>>>>>> utf8 aware...<br>
>>>>>>> In which case the server re-interprets bad characters for building the<br>
>>>>>>> .mcd and put them in patch.bin stone<br>
>>>>>>> Makes sense?<br>
>>>>>>><br>
>>>>>>> Is it possible to backport the utf8 correction to the server ?<br>
>>>>>>> I mean, is it going to cause forward compatibility problems ?<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> 2013/7/30 Bert Freudenberg <<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>><br>
>>>>>>>><br>
>>>>>>>> If the MCZ works and the MCD does not, then whatever fix we make needs<br>
>>>>>>>> to be applied to our squeaksource server image, which generates the MCDs.<br>
>>>>>>>><br>
>>>>>>>> - Bert -<br>
>>>>>>>><br>
>>>>>>>> On 2013-07-30, at 14:59, Nicolas Cellier<br>
>>>>>>>> <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
>>>>>>>><br>
>>>>>>>> I tried to debug late at night and it seems to come from the patch.bin<br>
>>>>>>>> member of a .mcd<br>
>>>>>>>> I'm not an expert of MC and I do not really know when a .mcd is used<br>
>>>>>>>> vs a .mcz, nor how this binary member is created.<br>
>>>>>>>> But presumably, there is an extra or missing utf8 conversion in some<br>
>>>>>>>> path...<br>
>>>>>>>> I had to stop to get some sleep...<br>
>>>>>>>> I suggest we keep trying a couple of days and solve the problem while<br>
>>>>>>>> under our hands.<br>
>>>>>>>><br>
>>>>>>>> Nicolas<br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> 2013/7/30 Frank Shearar <<a href="mailto:frank.shearar@gmail.com">frank.shearar@gmail.com</a>><br>
>>>>>>>>><br>
>>>>>>>>> On 30 July 2013 02:17, Nicolas Cellier<br>
>>>>>>>>> <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
>>>>>>>>>> Hmm it looks like some UTF8 mess<br>
>>>>>>>>>> I did only change Base64MimeConverter... Did I break it?<br>
>>>>>>>>><br>
>>>>>>>>> Yep, I'm afraid so. When it loads it throws a SyntaxError:<br>
>>>>>>>>><br>
>>>>>>>>> asCharacter<br>
>>>>>>>>> "Answer the receiver's first character, or '*' if none.<br>
>>>>>>>>> Idiosyncratic, provisional."<br>
>>>>>>>>><br>
>>>>>>>>> ^ self size > 0 ifTrue: [self first] ifFalse:[$·Argument expected<br>
>>>>>>>>> ->]<br>
>>>>>>>>><br>
>>>>>>>>> Is that supposed to be a middle dot just before "Argument" ? Note how<br>
>>>>>>>>> the original source doesn't show the A-with-caret.<br>
>>>>>>>>><br>
>>>>>>>>> frank<br>
>>>>>>>>><br>
>>>>>>>>>> 2013/7/30 <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>><br>
>>>>>>>>>><br>
>>>>>>>>>>> Nicolas Cellier uploaded a new version of Collections to project<br>
>>>>>>>>>>> The<br>
>>>>>>>>>>> Trunk:<br>
>>>>>>>>>>> <a href="http://source.squeak.org/trunk/Collections-nice.527.mcz" target="_blank">http://source.squeak.org/trunk/Collections-nice.527.mcz</a><br>
>>>>>>>>>>><br>
>>>>>>>>>>> ==================== Summary ====================<br>
>>>>>>>>>>><br>
>>>>>>>>>>> Name: Collections-nice.527<br>
>>>>>>>>>>> Author: nice<br>
>>>>>>>>>>> Time: 30 July 2013, 2:13:07.506 am<br>
>>>>>>>>>>> UUID: 17e38fb5-76dd-499b-aa6d-bfe07045c28d<br>
>>>>>>>>>>> Ancestors: Collections-fbs.526<br>
>>>>>>>>>>><br>
>>>>>>>>>>> Simplify Base64MimeConverter class initialization with<br>
>>>>>>>>>>> Character>>to:<br>
>>>>>>>>>>><br>
>>>>>>>>>>> =============== Diff against Collections-fbs.526 ===============<br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>><br>
>>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>><br>
><br>
> - Bert -<br>
><br>
><br>
><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">- Bert -<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div>