<div dir="ltr">On Mon, Aug 12, 2013 at 11:09 AM, Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On 12 August 2013 16:42, Bert Freudenberg <<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>> wrote:<br>
> On 2013-08-12, at 14:53, <a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a> wrote:<br>
><br>
>> checkForUpdates<br>
>> | availableUpdate updateServer |<br>
>> World<br>
>> ifNotNil: [<br>
>> World install.<br>
>> ActiveHand position: 100@100].<br>
>> - HTTPClient isRunningInBrowser<br>
>> - ifFalse: [^self processUpdates].<br>
>> availableUpdate := (AbstractLauncher extractParameters<br>
>> at: 'UPDATE'<br>
>> ifAbsent: [''] ) asInteger.<br>
>> availableUpdate<br>
>> ifNil: [^false].<br>
>> updateServer := AbstractLauncher extractParameters<br>
>> at: 'UPDATESERVER'<br>
>> ifAbsent: [AbstractLauncher extractParameters<br>
>> at: 'UPDATE_SERVER'<br>
>> ifAbsent: ['Squeakland']].<br>
>> Utilities setUpdateServer: updateServer.<br>
>> ^SystemVersion checkAndApplyUpdates: availableUpdate!<br>
><br>
><br>
> This change would always execute the case meant for the web-browser plugin. (this whole mechanism is unused anyway, even in Etoys, but still)<br>
<br>
</div>Right. I was expecting to hear that this particular change was bad. My<br>
preference would be to rip it out completely. Or, at most, preserve it<br>
in 45Deprecated, or elsewhere. AncientUpdateStream or something.<br>
<div class="im"><br>
> Also, what's wrong with "Utilities updateFromServer"? Seems to me much nicer and easier to remember than "MCMcmUpdater updateFromServer". Call it a Facade, if you need to appease the gods of agile ;)<br>
<br>
</div>* I want Utilities to die. It's a mess of mixed responsibilities. Even<br>
were that all cleaned up, it'd be a mess of mixed responsibilities<br>
delegated to better suited places. It's Bad(tm) for modularity:<br>
Utilities >> #updateFromServer makes System depend on<br>
MonticelloConfiguration, which is already dependent on System.<br>
Breaking that cycle is the whole point of this commit.<br>
<br>
* With MCMcmUpdater >> #updateFromServer we concentrate updating in one place.<br>
<br></blockquote><div>But, Utilities>>updateFromServer is a facade with a purpose. If you go back to 3.11 or so, you'll see that does not use Monticello at all - it used the old update server scheme (which stored change sets). </div>
<div>(it looked something like:</div><div><div>updateFromServer</div><div><span class="" style="white-space:pre"> </span>self readServerUpdatesSaveLocally: Preferences updateSavesFile updateImage: true</div></div><div>)</div>
<div><br></div><div> I can see a future where we'll move off of Montecello - not sure which decade, but I'd be surprised if we didn't.</div><div><br></div><div>What if you (we?) made a new package Utilities that held these types of items? Or, better yet, what is a pragma was added that Utilities used to pickup where it should forward on the commands that are needed to perform it's tasks?</div>
<div><br></div><div>-Chris </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
frank<br>
<br>
> - Bert -<br>
><br>
><br>
><br>
<br>
</blockquote></div><br></div></div>